Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] sale_sourced_by_line: Migration to 18.0 #3496

Merged
merged 60 commits into from
Jan 31, 2025

Conversation

ajay-odoogap
Copy link

@ajay-odoogap ajay-odoogap changed the title 18.0 mig sale sourced by line [18.0][MIG] sale_sourced_by_line: Migration to 18.0 Dec 17, 2024
@ajay-odoogap ajay-odoogap force-pushed the 18.0-mig-sale_sourced_by_line branch from 39796dd to 9bf51c3 Compare December 17, 2024 06:16
guewen and others added 28 commits January 13, 2025 16:07
…dule sale_sourced_by_line

(/tmp/trunk-generic/ rev 27)
(/tmp/trunk-generic/ rev 40.1.6)
Now allows to set a warehouse on sale order line

Added a test for sale order with multiple warehouses sources
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
This module extract logic to create multiple procurement group
for a single sale order for grouped sale order lines.
mymage and others added 13 commits January 13, 2025 16:07
Currently translated at 50.0% (2 of 4 strings)

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_sourced_by_line
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_sourced_by_line/it/
Currently translated at 100.0% (4 of 4 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_sourced_by_line
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_sourced_by_line/de/
Currently translated at 100.0% (4 of 4 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_sourced_by_line
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_sourced_by_line/it/
Currently translated at 100.0% (4 of 4 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_sourced_by_line
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_sourced_by_line/es/
Currently translated at 100.0% (4 of 4 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_sourced_by_line
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_sourced_by_line/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-17.0/sale-workflow-17.0-sale_sourced_by_line
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_sourced_by_line/
Currently translated at 100.0% (6 of 6 strings)

Translation: sale-workflow-17.0/sale-workflow-17.0-sale_sourced_by_line
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_sourced_by_line/it/
@ajay-odoogap ajay-odoogap force-pushed the 18.0-mig-sale_sourced_by_line branch from 9bf51c3 to e071c42 Compare January 13, 2025 10:40
Copy link
Member

@antonioburic antonioburic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review only.
Thanks for the port! It would also be nice to squash some administrative commits where possible.

Comment on lines +29 to +32
"""compute the warehouse for the lines only
if it has not already been set."""
lines = self.filtered(lambda rec: not rec.warehouse_id)
return super(SaleOrderLine, lines)._compute_warehouse_id()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to do this exactly, given that it's already computed in the core?
the depends also do not change ^^

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonioburic to ensure that the warehouse manually set on the sale order line is not recomputed when the warehouse is changed at the sale order level

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah indeed, thx!

Copy link

@Ricardo-MC Ricardo-MC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me,
thanks for the work

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Contributor

@celm1990 celm1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@pedrobaeza Could you please review this? Thanks in advance.

@pedrobaeza
Copy link
Member

/ocabot migration sale_sourced_by_line
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jan 31, 2025
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-3496-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Jan 31, 2025
56 tasks
@OCA-git-bot OCA-git-bot merged commit 39be78c into OCA:18.0 Jan 31, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0b4bcad. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.