-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] sale_sourced_by_line: Migration to 18.0 #3496
Conversation
39796dd
to
9bf51c3
Compare
…dule sale_sourced_by_line (/tmp/trunk-generic/ rev 27)
(/tmp/trunk-generic/ rev 29)
(/tmp/trunk-generic/ rev 29.1.20)
(/tmp/trunk-generic/ rev 40.1.6)
- Update travis.yml to 8.0
Now allows to set a warehouse on sale order line Added a test for sale order with multiple warehouses sources
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
This module extract logic to create multiple procurement group for a single sale order for grouped sale order lines.
Currently translated at 50.0% (2 of 4 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_sourced_by_line Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_sourced_by_line/it/
Currently translated at 100.0% (4 of 4 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_sourced_by_line Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_sourced_by_line/de/
Currently translated at 100.0% (4 of 4 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_sourced_by_line Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_sourced_by_line/it/
Currently translated at 100.0% (4 of 4 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_sourced_by_line Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_sourced_by_line/es/
Currently translated at 100.0% (4 of 4 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_sourced_by_line Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_sourced_by_line/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-17.0/sale-workflow-17.0-sale_sourced_by_line Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_sourced_by_line/
Currently translated at 100.0% (6 of 6 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_sourced_by_line Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_sourced_by_line/it/
[FIX] pylint error
9bf51c3
to
e071c42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technical review only.
Thanks for the port! It would also be nice to squash some administrative commits where possible.
"""compute the warehouse for the lines only | ||
if it has not already been set.""" | ||
lines = self.filtered(lambda rec: not rec.warehouse_id) | ||
return super(SaleOrderLine, lines)._compute_warehouse_id() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to do this exactly, given that it's already computed in the core?
the depends also do not change ^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antonioburic to ensure that the warehouse manually set on the sale order line is not recomputed when the warehouse is changed at the sale order level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah indeed, thx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me,
thanks for the work
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pedrobaeza Could you please review this? Thanks in advance.
/ocabot migration sale_sourced_by_line |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 0b4bcad. Thanks a lot for contributing to OCA. ❤️ |
Note