[16.0][MIG] sale_invoice_plan, standard migration to 16.0 #2988
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,7 +60,7 @@ | |
| string="Invoices", | ||
| readonly=True, | ||
| ) | ||
| amount_invoiced = fields.Float(compute="_compute_invoiced", store=True) | ||
| to_invoice = fields.Boolean( | ||
| string="Next Invoice", | ||
| compute="_compute_to_invoice", | ||
|
|
@@ -69,6 +69,7 @@ | |
| invoiced = fields.Boolean( | ||
| string="Invoice Created", | ||
| compute="_compute_invoiced", | ||
| store=True, | ||
| help="If this line already invoiced", | ||
| ) | ||
| no_edit = fields.Boolean( | ||
|
|
@@ -123,7 +124,7 @@ | |
| continue | ||
| rec.percent = rec.amount / rec.sale_id.amount_untaxed * 100 | ||
| continue | ||
| rec.percent = 0 | ||
|
|
||
| def _compute_to_invoice(self): | ||
| """If any invoice is in draft/open/paid do not allow to create inv. | ||
|
|
@@ -133,7 +134,7 @@ | |
| rec.to_invoice = False | ||
| for rec in self.sorted("installment"): | ||
| if rec.state != "sale": # Not confirmed, no to_invoice | ||
| continue | ||
| if not rec.invoiced: | ||
| rec.to_invoice = True | ||
| break | ||
|
|
@@ -153,12 +154,13 @@ | |
| amount_invoiced = sum(lines.mapped("price_subtotal")) | ||
| return amount_invoiced | ||
|
|
||
| @api.depends("invoice_move_ids.state") | ||
|
There was a problem hiding this comment. @kittiu What's the impact of this on existing database in terms of upgrade performance? There was a problem hiding this comment. Really not sure about this. But I doubt that this will be relevant to update the module? Since state is not changing. Do you foresee problem? |
||
| def _compute_invoiced(self): | ||
| for rec in self: | ||
| invoiced = rec.invoice_move_ids.filtered( | ||
| lambda l: l.state in ("draft", "posted") | ||
| ) | ||
| rec.invoiced = True if invoiced else False | ||
| rec.amount_invoiced = ( | ||
| sum(invoiced.mapped("amount_untaxed")) | ||
| if rec.invoice_type == "advance" | ||
|
|
@@ -178,13 +180,15 @@ | |
| move = invoice_move.with_context(check_move_validity=False) | ||
| for line in move.invoice_line_ids: | ||
| self._update_new_quantity(line, percent) | ||
| move.line_ids.filtered( | ||
| lambda x: x.display_type | ||
| not in ("product", "line_section", "line_note", "payment_term", "tax") | ||
| ).unlink() | ||
|
|
||
| def _update_new_quantity(self, line, percent): | ||
| """Hook function""" | ||
| if not len(line.sale_line_ids) >= 0: | ||
| raise UserError(_("No matched order line for invoice line")) | ||
| order_line = fields.first(line.sale_line_ids) | ||
| if order_line.is_downpayment: # based on 1 unit | ||
| line.write({"quantity": -percent / 100}) | ||
|
|
@@ -194,7 +198,7 @@ | |
| if plan_qty: | ||
| plan_qty = float_round(plan_qty, precision_rounding=prec) | ||
| if float_compare(abs(plan_qty), abs(line.quantity), prec) == 1: | ||
| raise ValidationError( | ||
| _( | ||
| "Plan quantity: %(plan_qty)s, exceed invoiceable quantity: " | ||
| "%(invoiceable_qty)s" | ||
|
|
@@ -212,8 +216,8 @@ | |
| def unlink(self): | ||
| lines = self.filtered("no_edit") | ||
| if lines: | ||
| installments = [str(x) for x in lines.mapped("installment")] | ||
| raise UserError( | ||
| _( | ||
| "Installment %s: already used and not allowed to delete.\n" | ||
| "Please discard changes." | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,10 +8,11 @@ | |
|
|
||
| /* | ||
| :Author: David Goodger ([email protected]) | ||
| :Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $ | ||
| :Copyright: This stylesheet has been placed in the public domain. | ||
|
|
||
| Default cascading style sheet for the HTML output of Docutils. | ||
| Despite the name, some widely supported CSS2 features are used. | ||
|
|
||
| See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to | ||
| customize this style sheet. | ||
|
|
@@ -274,7 +275,7 @@ | |
| margin-left: 2em ; | ||
| margin-right: 2em } | ||
|
|
||
| pre.code .ln { color: gray; } /* line numbers */ | ||
| pre.code, code { background-color: #eeeeee } | ||
| pre.code .comment, code .comment { color: #5C6576 } | ||
| pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold } | ||
|
|
@@ -300,7 +301,7 @@ | |
| span.pre { | ||
| white-space: pre } | ||
|
|
||
| span.problematic, pre.problematic { | ||
| color: red } | ||
|
|
||
| span.section-subtitle { | ||
|
|
@@ -368,7 +369,7 @@ <h1 class="title">Sales Invoice Plan</h1> | |
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| !! source digest: sha256:09c96dddef2659c83a39fc88dc4ff76d555da27304bfcf1e9ba82d7639831bb7 | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! --> | ||
| <p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Alpha" src="https://img.shields.io/badge/maturity-Alpha-red.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/sale-workflow/tree/16.0/sale_invoice_plan"><img alt="OCA/sale-workflow" src="https://img.shields.io/badge/github-OCA%2Fsale--workflow-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_invoice_plan"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/sale-workflow&target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p> | ||
| <p>By standard feature, user can gradually create partial invoices, one by one. | ||
| This module add ability to create invoices based on the predefined invoice plan, | ||
| either all at once, or one by one. | ||
|
|
@@ -435,7 +436,7 @@ <h1><a class="toc-backref" href="#toc-entry-6">Bug Tracker</a></h1> | |
| <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/sale-workflow/issues">GitHub Issues</a>. | ||
| In case of trouble, please check there if your issue has already been reported. | ||
| If you spotted it first, help us to smash it by providing a detailed and welcomed | ||
| <a class="reference external" href="https://github.com/OCA/sale-workflow/issues/new?body=module:%20sale_invoice_plan%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p> | ||
| <p>Do not contact contributors directly about support or help with technical issues.</p> | ||
| </div> | ||
| <div class="section" id="credits"> | ||
|
|
@@ -467,13 +468,15 @@ <h2><a class="toc-backref" href="#toc-entry-10">Other credits</a></h2> | |
| <div class="section" id="maintainers"> | ||
| <h2><a class="toc-backref" href="#toc-entry-11">Maintainers</a></h2> | ||
| <p>This module is maintained by the OCA.</p> | ||
| <a class="reference external image-reference" href="https://odoo-community.org"> | ||
| <img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /> | ||
| </a> | ||
| <p>OCA, or the Odoo Community Association, is a nonprofit organization whose | ||
| mission is to support the collaborative development of Odoo features and | ||
| promote its widespread use.</p> | ||
| <p>Current <a class="reference external" href="https://odoo-community.org/page/maintainer-role">maintainer</a>:</p> | ||
| <p><a class="reference external image-reference" href="https://github.com/kittiu"><img alt="kittiu" src="https://github.com/kittiu.png?size=40px" /></a></p> | ||
| <p>This module is part of the <a class="reference external" href="https://github.com/OCA/sale-workflow/tree/16.0/sale_invoice_plan">OCA/sale-workflow</a> project on GitHub.</p> | ||
| <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p> | ||
| </div> | ||
| </div> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dreispt just FYI, I saw this part of code that you try to refactor on your code is incorrect. This might be the reason that advance is not working?
I try to refactor here too, this will remain the same logic and it works for me.