Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] sale_cancel_reason #2483

Merged
merged 61 commits into from
Apr 20, 2023
Merged

[16.0][MIG] sale_cancel_reason #2483

merged 61 commits into from
Apr 20, 2023

Conversation

hugo-cordoba
Copy link
Contributor

@hugo-cordoba hugo-cordoba commented Apr 17, 2023 •
edited
Loading

16.0 mig sale_cancel_reason

guewen and others added 30 commits April 17, 2023 13:03
@guewen
[MRG] from master branch
2c0868b 
(../trunk-generic/ rev 29.1.1)
@nbessi
[FIX] sale cancel reason dependence
6b825a3 
(../trunk-generic/ rev 32.1.1)
@guewen
[FIX] sale_cancel_reason: remove dependency on sale_stock
2f1a3c5 
(../trunk-generic/ rev 32.1.2)
@gurneyalex
spellcheck
41ba48c
@eLBati
[FIX] repository PEP8
ef3f054
@eLBati
[FIX] Still some PEP8 erros
f316f96
@pedrobaeza
- Set as uninstallable and moved to __unported__ dir all modules.
7801a98 
- Update travis.yml to 8.0
@yvaucher
reactivate sale_cancel_reason
118e0a1
@yvaucher
port models and method to api 8.0
0a9082c
@yvaucher
Improve override of cancel button to ease inheritance of view
8f2341a 
Only hide button instead of renaming it
@rdeheele
[FIX] typo on class name
eb27869
@gurneyalex
Add OCA as author of OCA addons
802fe49 
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
@mlaitinen
Added Finnish translations
f50a684
@dhp-denero
[FIX] cancel button of orignal view should be hide after installation…
c657148 
… of sale_cancel_reason module
@yvaucher
Add missing default oca icons
e6b2d3a
@sysadminmatmoz
Slovene translations added
7e5daf2
@yvaucher
bump version of sale_cancel_reason
86ff613
@oca-transbot
OCA Transbot updated translations from Transifex
165544e
@pedrobaeza
[MIG] Make modules uninstallable
cd1b42f
@sbidoul
[FIX] remove en.po that was erroneously created by transbot
bee1a9e
@pedrobaeza
[MIG] Rename manifest files
92c9b65
@kittiu
[MIG] sale_cancel_reason Migration to 10.0 (OCA#477)
f587545 
* [MIG] sale_cancel_reason Migration to 10.0

* Follow coding standard

* Convert test to unittest2
@sbidoul
remove obsolete .pot files [ci skip]
90856cd
@oca-travis
[UPD] Update sale_cancel_reason.pot
81b3c3d
@oca-transbot
Update translation files
3cea997 
Updated by Actualizar ficheiros PO com o novo POT (msgmerge) hook in Weblate.
@pedrocs-exo
Translated using Weblate (Portuguese)
4952f19 
Currently translated at 100.0% (23 of 23 strings)

Translation: sale-workflow-10.0/sale-workflow-10.0-sale_cancel_reason
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_cancel_reason/pt/
[MIG] sale_cancel_reason: Migration to 12.0
1b894e3
@OCA-git-bot
[UPD] README.rst
9d45b4c
@oca-travis
[UPD] Update sale_cancel_reason.pot
ae9bfd0
@oca-transbot
Update translation files
b107752 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_cancel_reason
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_cancel_reason/
@hugo-cordoba hugo-cordoba mentioned this pull request Apr 17, 2023
Open
@hugo-cordoba hugo-cordoba force-pushed the 16.0-mig-sale_cancel_reason branch from 614404a to 6b9d4ec Compare April 17, 2023 14:46
@hugo-cordoba hugo-cordoba force-pushed the 16.0-mig-sale_cancel_reason branch from 6b9d4ec to caa31db Compare April 17, 2023 14:47
@hugo-cordoba hugo-cordoba force-pushed the 16.0-mig-sale_cancel_reason branch from 43ca0b5 to 97ab626 Compare April 18, 2023 15:21
@hugo-cordoba
Copy link
Contributor Author

hugo-cordoba commented Apr 18, 2023 •
edited
Loading

hi @rousseldenis, could you check this code and merge this development?

best regards

@rousseldenis
Copy link
Contributor

/ocabot migration sale_cancel_reason

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Apr 20, 2023
@hugo-cordoba
Copy link
Contributor Author

Hi @pedrobaeza could you trigger the merge?

Regards.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@pedrobaeza pedrobaeza changed the title 16.0 mig sale cancel reason [16.0][MIG] sale_cancel_reason Apr 20, 2023
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2483-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1dc72cc into OCA:16.0 Apr 20, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2068a3a. Thanks a lot for contributing to OCA. ❤️

@hugo-cordoba hugo-cordoba deleted the 16.0-mig-sale_cancel_reason branch April 20, 2023 09:34
@AaronHForgeFlow
Copy link
Contributor

Next time, please check there are other PR open for the same module #2401

@hugo-cordoba
Copy link
Contributor Author

Hi @AaronHForgeFlow.

I don't see that he had commented that he was migrating the module in the migration task #2215.

To avoid this on future occasions, it is advisable when you start migrating a module, to add a comment in the migration task so that the rest of us know about it.

Best regards!

@pedrobaeza
Copy link
Member

Sorry, I didn't check either. I usually look for other PRs before doing this, but this time was direct.

@AaronHForgeFlow
Copy link
Contributor

No worries, it happened to me in the past too. BR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flalexg flalexg flalexg approved these changes

@aliciagaarzo aliciagaarzo aliciagaarzo approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.