[15.0][mig]-sale_validity_auto_cancel #2335
Conversation
|
/ocabot migration sale_validity_auto_cancel |
|
@LoisRForgeFlow Is this still applicable? |
|
Not sure about this one, probably @JordiMForgeFlow will know better as author. |
JordiMForgeFlow
force-pushed
the
15.0-mig-sale_validity_auto-cancel
branch
2 times, most recently
from
78d346a to
166c34b
Compare
|
@rousseldenis yes, it is ready. I think we could close #3117 in favor of this one |
|
/ocabot migration sale_validity_auto_cancel |
| @@ -28,6 +28,6 @@ def cron_sale_validity_auto_cancel(self): | |||
| ) | |||
| for order in orders: | |||
| try: | |||
| order.with_context(company_id=company.id)._action_cancel() | |||
| order.with_company(company.id)._action_cancel() | |||
There was a problem hiding this comment.
In fact, I'm not sure about the loop validity.
IMHO, you should search for sales with company of the current loop state.
Then, you should do for order in orders.with_company(company.id):
There was a problem hiding this comment.
True, should be fixed now
JordiMForgeFlow
force-pushed
the
15.0-mig-sale_validity_auto-cancel
branch
2 times, most recently
from
a2c90f2 to
23a558d
Compare
|
@JordiMForgeFlow Could you just fix the typo in commit message ?
|
JordiMForgeFlow
force-pushed
the
15.0-mig-sale_validity_auto-cancel
branch
from
23a558d to
bef6a26
Compare
|
@rousseldenis done :) |
|
We can go further. /ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at e0352c9. Thanks a lot for contributing to OCA. ❤️ |
@ForgeFlow
Migration to 15.0