[16.0][MIG] sale_start_end_dates #2327
Conversation
vancouver29
force-pushed
the
16.0-mig-sale_start_end_dates
branch
13 times, most recently
from
3c1488f to
f3bb874
Compare
|
/ocabot migration sale_start_end_dates |
|
@vancouver29 Thanks for this. Could you follow migration guide in order to have two commits (one for pre-commit, one for migration). https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0 |
| @@ -96,7 +96,7 @@ def _inverse_number_of_days(self): | |||
| number_of_days=line.number_of_days, | |||
| ) | |||
| line.number_of_days = 1 | |||
| if line.start_date: | |||
| if line.start_date and not line.end_date: | |||
There was a problem hiding this comment.
Shouldn't the end date converted into computed field readonly False ?
| @@ -160,12 +160,12 @@ def start_end_dates_product_id_change(self): | |||
| if self.product_id.must_have_dates: | |||
| if self.order_id.default_start_date: | |||
| self.start_date = self.order_id.default_start_date | |||
| else: | |||
| self.start_date = False | |||
| # else: | |||
There was a problem hiding this comment.
Please remove unused code
|
@vancouver29 Could you also convert your PR title to human readable one ? Like '[16.0][MIG] sale_start_end_dates'. Thanks |
Replace openerp by odoo in import declarations
Currently translated at 100,0% (16 of 16 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_start_end_dates/nl_NL/
Currently translated at 26.7% (4 of 15 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_start_end_dates/pt/
vancouver29
force-pushed
the
16.0-mig-sale_start_end_dates
branch
from
f3bb874 to
556ac39
Compare
vancouver29
changed the title
|
@rousseldenis FYI |
|
|
||
| def test_prepare_invoice_line(self): | ||
| invoice_line_vals = self.so.order_line._prepare_invoice_line() | ||
| self.assertEqual(invoice_line_vals["product_id"], self.product_id.id) |
There was a problem hiding this comment.
we can add two more lines here to check start_date and end_date on invoice line
self.assertEqual(invoice_line_vals["start_date"], self.so.order_line[0].start_date)
self.assertEqual(invoice_line_vals["end_date"], self.so.order_line[0].end_date)
There was a problem hiding this comment.
@chandni299 i added these lines
vancouver29
force-pushed
the
16.0-mig-sale_start_end_dates
branch
from
556ac39 to
4842535
Compare
|
Hi, looks good to me. |
|
Maybe, can you rebase your branch with main branch? |
|
I improved this PR by converting onchange to compute methods, cf this other PR #2577 |
|
@vancouver29 Do you mind if we switch to #2577 ? |
|
The module has been merged in v16, we can now close this PR |
No description provided.