[IMP] sale_global_discount: pre-commit auto fixes

sale_global_discount/README.rst

@@ -17,19 +17,19 @@ Sale Global Discount
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fsale--workflow-lightgray.png?logo=github
-    :target: https://github.com/OCA/sale-workflow/tree/16.0/sale_global_discount
+    :target: https://github.com/OCA/sale-workflow/tree/17.0/sale_global_discount
     :alt: OCA/sale-workflow
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_global_discount
+    :target: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_global_discount
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/sale-workflow&target_branch=16.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/sale-workflow&target_branch=17.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
 
-Apply global financial discounts to sales that will be transmited to invoices
-and accounting.
+Apply global financial discounts to sales that will be transmited to
+invoices and accounting.
 
 **Table of contents**
 
@@ -39,58 +39,62 @@ and accounting.
 Configuration
 =============
 
-To configure this module please refer to configure section of the `base_global_discount` module.
+To configure this module please refer to configure section of the
+base_global_discount module.
 
 Usage
 =====
 
 To use this module, you need to:
 
-#. See usage section of the `base_global_discount` module.
-#. Create a new sale order and choose a partner.
-#. If the partner has customer global discounts set, those will be applied to
-   the order by default.
-#. Otherwise, you can set them manually from the header of the sale order.
-#. In the order footer, you can see the computed discounts.
-#. When you create an invoice from the order, the proper global discounts will
-   be applied on it.
+1. See usage section of the base_global_discount module.
+2. Create a new sale order and choose a partner.
+3. If the partner has customer global discounts set, those will be
+   applied to the order by default.
+4. Otherwise, you can set them manually from the header of the sale
+   order.
+5. In the order footer, you can see the computed discounts.
+6. When you create an invoice from the order, the proper global
+   discounts will be applied on it.
 
 Known issues / Roadmap
 ======================
 
-* Not all the taxes combination can be compatible with global discounts. An
-  error is raised in that cases.
-* Currently, taxes in invoice lines are mandatory with global discounts.
+-  Not all the taxes combination can be compatible with global
+   discounts. An error is raised in that cases.
+-  Currently, taxes in invoice lines are mandatory with global
+   discounts.
 
 Bug Tracker
 ===========
 
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/sale-workflow/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/sale-workflow/issues/new?body=module:%20sale_global_discount%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/sale-workflow/issues/new?body=module:%20sale_global_discount%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
 Credits
 =======
 
 Authors
-~~~~~~~
+-------
 
 * Tecnativa
 
 Contributors
-~~~~~~~~~~~~
+------------
 
-* `Tecnativa <https://www.tecnativa.com>`_
+-  `Tecnativa <https://www.tecnativa.com>`__
 
-  * David Vidal
-  * Pedro M. Baeza
-* Omar Castiñeira <[email protected]>
+   -  David Vidal
+   -  Pedro M. Baeza
+
+-  Omar Castiñeira <[email protected]>
 
 Maintainers
-~~~~~~~~~~~
+-----------
 
 This module is maintained by the OCA.
 
@@ -102,6 +106,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/sale-workflow <https://github.com/OCA/sale-workflow/tree/16.0/sale_global_discount>`_ project on GitHub.
+This module is part of the `OCA/sale-workflow <https://github.com/OCA/sale-workflow/tree/17.0/sale_global_discount>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

sale_global_discount/models/sale_order.py

@@ -141,10 +141,13 @@ def _compute_tax_totals(self):
 
     @api.onchange("partner_id")
     def onchange_partner_id_set_gbl_disc(self):
-        self.global_discount_ids = self.partner_id.customer_global_discount_ids.filtered(
-            lambda d: d.company_id == self.company_id
-        ) or self.partner_id.commercial_partner_id.customer_global_discount_ids.filtered(
-            lambda d: d.company_id == self.company_id
+        self.global_discount_ids = (
+            self.partner_id.customer_global_discount_ids.filtered(
+                lambda d: d.company_id == self.company_id
+            )
+            or self.partner_id.commercial_partner_id.customer_global_discount_ids.filtered(
+                lambda d: d.company_id == self.company_id
+            )
         )
 
     def _prepare_invoice(self):

sale_global_discount/pyproject.toml

@@ -0,0 +1,3 @@
+[build-system]
+requires = ["whool"]
+build-backend = "whool.buildapi"

sale_global_discount/readme/CONFIGURE.rst → sale_global_discount/readme/CONFIGURE.md

@@ -1 +1,2 @@
-To configure this module please refer to configure section of the `base_global_discount` module.
+To configure this module please refer to configure section of the
+base_global_discount module.

sale_global_discount/readme/CONTRIBUTORS.md

@@ -0,0 +1,4 @@
+- [Tecnativa](https://www.tecnativa.com)
+  - David Vidal
+  - Pedro M. Baeza
+- Omar Castiñeira \<<[email protected]>\>

sale_global_discount/readme/DESCRIPTION.rst → sale_global_discount/readme/DESCRIPTION.md

@@ -1,2 +1,2 @@
-Apply global financial discounts to sales that will be transmited to invoices
-and accounting.
+Apply global financial discounts to sales that will be transmited to
+invoices and accounting.

sale_global_discount/readme/ROADMAP.md

@@ -0,0 +1,3 @@
+- Not all the taxes combination can be compatible with global discounts.
+  An error is raised in that cases.
+- Currently, taxes in invoice lines are mandatory with global discounts.

sale_global_discount/readme/USAGE.md

@@ -0,0 +1,11 @@
+To use this module, you need to:
+
+1.  See usage section of the base_global_discount module.
+2.  Create a new sale order and choose a partner.
+3.  If the partner has customer global discounts set, those will be
+    applied to the order by default.
+4.  Otherwise, you can set them manually from the header of the sale
+    order.
+5.  In the order footer, you can see the computed discounts.
+6.  When you create an invoice from the order, the proper global
+    discounts will be applied on it.

sale_global_discount/static/description/index.html

@@ -8,10 +8,11 @@
 
 /*
 :Author: David Goodger ([email protected])
-:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
+:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
 :Copyright: This stylesheet has been placed in the public domain.
 
 Default cascading style sheet for the HTML output of Docutils.
+Despite the name, some widely supported CSS2 features are used.
 
 See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
 customize this style sheet.
@@ -274,7 +275,7 @@
   margin-left: 2em ;
   margin-right: 2em }
 
-pre.code .ln { color: grey; } /* line numbers */
+pre.code .ln { color: gray; } /* line numbers */
 pre.code, code { background-color: #eeeeee }
 pre.code .comment, code .comment { color: #5C6576 }
 pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
@@ -300,7 +301,7 @@
 span.pre {
   white-space: pre }
 
-span.problematic {
+span.problematic, pre.problematic {
   color: red }
 
 span.section-subtitle {
@@ -368,9 +369,9 @@ <h1 class="title">Sale Global Discount</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:308d1f4b778a286e7914857091bbaa912e44faf68ffe5678f48c8bfe6f52168a
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/sale-workflow/tree/16.0/sale_global_discount"><img alt="OCA/sale-workflow" src="https://img.shields.io/badge/github-OCA%2Fsale--workflow-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_global_discount"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/sale-workflow&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
-<p>Apply global financial discounts to sales that will be transmited to invoices
-and accounting.</p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/sale-workflow/tree/17.0/sale_global_discount"><img alt="OCA/sale-workflow" src="https://img.shields.io/badge/github-OCA%2Fsale--workflow-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_global_discount"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/sale-workflow&amp;target_branch=17.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p>Apply global financial discounts to sales that will be transmited to
+invoices and accounting.</p>
 <p><strong>Table of contents</strong></p>
 <div class="contents local topic" id="contents">
 <ul class="simple">
@@ -388,36 +389,39 @@ <h1 class="title">Sale Global Discount</h1>
 </div>
 <div class="section" id="configuration">
 <h1><a class="toc-backref" href="#toc-entry-1">Configuration</a></h1>
-<p>To configure this module please refer to configure section of the <cite>base_global_discount</cite> module.</p>
+<p>To configure this module please refer to configure section of the
+base_global_discount module.</p>
 </div>
 <div class="section" id="usage">
 <h1><a class="toc-backref" href="#toc-entry-2">Usage</a></h1>
 <p>To use this module, you need to:</p>
 <ol class="arabic simple">
-<li>See usage section of the <cite>base_global_discount</cite> module.</li>
+<li>See usage section of the base_global_discount module.</li>
 <li>Create a new sale order and choose a partner.</li>
-<li>If the partner has customer global discounts set, those will be applied to
-the order by default.</li>
-<li>Otherwise, you can set them manually from the header of the sale order.</li>
+<li>If the partner has customer global discounts set, those will be
+applied to the order by default.</li>
+<li>Otherwise, you can set them manually from the header of the sale
+order.</li>
 <li>In the order footer, you can see the computed discounts.</li>
-<li>When you create an invoice from the order, the proper global discounts will
-be applied on it.</li>
+<li>When you create an invoice from the order, the proper global
+discounts will be applied on it.</li>
 </ol>
 </div>
 <div class="section" id="known-issues-roadmap">
 <h1><a class="toc-backref" href="#toc-entry-3">Known issues / Roadmap</a></h1>
 <ul class="simple">
-<li>Not all the taxes combination can be compatible with global discounts. An
-error is raised in that cases.</li>
-<li>Currently, taxes in invoice lines are mandatory with global discounts.</li>
+<li>Not all the taxes combination can be compatible with global
+discounts. An error is raised in that cases.</li>
+<li>Currently, taxes in invoice lines are mandatory with global
+discounts.</li>
 </ul>
 </div>
 <div class="section" id="bug-tracker">
 <h1><a class="toc-backref" href="#toc-entry-4">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/sale-workflow/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/sale-workflow/issues/new?body=module:%20sale_global_discount%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/sale-workflow/issues/new?body=module:%20sale_global_discount%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -442,11 +446,13 @@ <h2><a class="toc-backref" href="#toc-entry-7">Contributors</a></h2>
 <div class="section" id="maintainers">
 <h2><a class="toc-backref" href="#toc-entry-8">Maintainers</a></h2>
 <p>This module is maintained by the OCA.</p>
-<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
+<a class="reference external image-reference" href="https://odoo-community.org">
+<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
+</a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/sale-workflow/tree/16.0/sale_global_discount">OCA/sale-workflow</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/sale-workflow/tree/17.0/sale_global_discount">OCA/sale-workflow</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>