[14.0][ADD] sale_coupon_free_shipping_default_product #236
Conversation
Chionne27
force-pushed
the
14.0-ADD-sale_coupon_free_shipping_default_product
branch
from
560b8a1 to
f48404f
Compare
| "website": "https://github.com/OCA/sale-promotion", | ||
| "license": "LGPL-3", | ||
| "installable": True, | ||
| "depends": ["sale_management", "stock", "coupon"], |
There was a problem hiding this comment.
Hi, thank you for your contribution @Chionne27.
Small change, i think there are unnecessary module dependencies. Could you please check?
I think that the only one needed is coupon
| "depends": ["sale_management", "stock", "coupon"], | |
| "depends": ["coupon"], |
There was a problem hiding this comment.
Oh thank you for the suggestion. Let me know if everything is ok
Chionne27
force-pushed
the
14.0-ADD-sale_coupon_free_shipping_default_product
branch
from
f48404f to
b9f2e02
Compare
There was a problem hiding this comment.
Code review LGTM.
@Chionne27 Adding some test would be nice!
Chionne27
force-pushed
the
14.0-ADD-sale_coupon_free_shipping_default_product
branch
from
b9f2e02 to
51e08cc
Compare
Chionne27
force-pushed
the
14.0-ADD-sale_coupon_free_shipping_default_product
branch
from
51e08cc to
4d1cbc1
Compare
|
Thank you @toita86 for the suggestion. Tests done |
|
Hi @pedrobaeza , this is the first OCA module from @Chionne27 :) What do you think? |
|
Sorry, the functional scope right now is out of what I can check, but merging being a new module and not detecting something weird in dependencies: /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
@pedrobaeza thank you |
|
Congratulations, your PR was merged at b5caf02. Thanks a lot for contributing to OCA. ❤️ |
No description provided.