Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] loyalty_initial_date_validity: New module #167

Merged
merged 1 commit into from
Oct 26, 2023
Merged

[16.0][ADD] loyalty_initial_date_validity: New module #167

merged 1 commit into from
Oct 26, 2023

Conversation

pilarvargas-tecnativa
Copy link
Contributor

@pilarvargas-tecnativa pilarvargas-tecnativa commented Oct 26, 2023 •
edited
Loading

@pilarvargas-tecnativa pilarvargas-tecnativa mentioned this pull request Oct 26, 2023
Merged
1 task
chienandalu
chienandalu approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Just a nitpick:

loyalty_initial_date_validity/readme/USAGE.rst Show resolved Hide resolved
ernesto-garcia-tecnativa
ernesto-garcia-tecnativa approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@ernesto-garcia-tecnativa ernesto-garcia-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-add-loyalty_initial_date_validity branch from 8910b12 to 9abd20a Compare October 26, 2023 16:52
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-167-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 968df0d into OCA:16.0 Oct 26, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b4a3cfe. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-add-loyalty_initial_date_validity branch October 26, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernesto-garcia-tecnativa ernesto-garcia-tecnativa ernesto-garcia-tecnativa approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pilarvargas-tecnativa @pedrobaeza @OCA-git-bot @chienandalu @ernesto-garcia-tecnativa