Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] base_report_to_printer: fix encoding #342

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

jbaudoux
Copy link
Contributor

@jbaudoux jbaudoux commented Dec 6, 2023

In Python3, os.write requires bytes-like object

cc @lmignon @rousseldenis

In Python3, os.write requires bytes-like object
@jbaudoux
Copy link
Contributor Author

jbaudoux commented Dec 6, 2023

You're so quick :)

Test added, ready to merge

@lmignon
Copy link

lmignon commented Dec 6, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-342-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@lmignon The merge process could not be finalized, because command git push origin 16.0-ocabot-merge-pr-342-by-lmignon-bump-patch:16.0 failed with output:

To https://github.com/OCA/report-print-send
 ! [rejected]        16.0-ocabot-merge-pr-342-by-lmignon-bump-patch -> 16.0 (fetch first)
error: failed to push some refs to 'https://***@github.com/OCA/report-print-send'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

@OCA-git-bot OCA-git-bot merged commit 6bc2939 into OCA:16.0 Dec 6, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d0723af. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants