[15.0][IMP] repair_refurbish_repair_stock_move: allow setting a repair order "to refurbish" in the middle of the process #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethod to improve inhertitability
…ve should be the repair order, the other stock moves related to the repair are already with that source document
…r "to refurbish" in the middle of the process. The stock moves are already created but in the middle the user decides the repair will be refurbish. Before this commit the stock moves are already created and they are not valid for the new approach. Also the repair refurbish move is not created. The solution consist of cancelling existing moves and recreating them It also covers the case when the repair passes from "to refurbish" to a normal repair
AaronHForgeFlow
force-pushed
the
15.0-fix-repair_refurbish_repair_stock_move
branch
from
e172831 to
e25152d
Compare
MiquelRForgeFlow
approved these changes
Sep 9, 2024
…efurbish the refurbish lot may not be selected so when it is selected, it should be assigned to existing stock moves
AaronHForgeFlow
force-pushed
the
15.0-fix-repair_refurbish_repair_stock_move
branch
from
51f1c70 to
fd5bbb6
Compare
LoisRForgeFlow
approved these changes
Sep 9, 2024
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 5a872c5. Thanks a lot for contributing to OCA. ❤️ |
MiquelRForgeFlow
deleted the
15.0-fix-repair_refurbish_repair_stock_move
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case where the stock moves are already created but in the middle the user decides the repair will be refurbish.
Before this fix the stock moves are already created and they are not valid for the new approach. Also
the repair refurbish move is not created.
The solution consist of cancelling existing moves and recreating them.
It also covers the case when the repair passes from "to refurbish" to a normal repair.
This also includes a needed improvement in dependent module:
[IMP] repair_stock_move: do the creation of stock moves in separate method to improve inheritabilityAdditionally, added a small improvement in repair_refurbish:
[IMP] repair_refurbish: the source document of the refurbish stock move should be the repair order, the other stock moves related to the repair are already with that source documentcc @ForgeFlow