Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][ADD] repair_scrap #37

Merged
merged 1 commit into from
Feb 7, 2024
Merged

[15.0][ADD] repair_scrap #37

merged 1 commit into from
Feb 7, 2024

Conversation

ThiagoMForgeFlow
Copy link

Add new module to manage repair scraps

@ForgeFlow

@ThiagoMForgeFlow ThiagoMForgeFlow force-pushed the 15.0-add-repair_scrap branch 3 times, most recently from efc71dd to fd3608e Compare November 20, 2023 10:18
AaronHForgeFlow
AaronHForgeFlow reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works good. Just a couple of comments:

in the repair type, the scrap location is not in the right position I think. It should be with the other locations:
scrap_location

Then, specially when removing parts, you may want to scrap those as well. But the wizard does not allow to scrap more products. I think the removed parts of the repair can be included, or at least, the user should be able to include them:

scrap_more_parts

AaronHForgeFlow
AaronHForgeFlow reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect now. Can you just put the default values for the repair order and the locations when adding lines in the scrap order?

image

AaronHForgeFlow
AaronHForgeFlow reviewed Nov 22, 2023
View reviewed changes
repair_scrap/wizards/repair_make_scrap.py Outdated

def action_create_scrap(self):
self._create_scrap()
return self.item_ids[0].repair_id.action_view_scrap_transfers()
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow Nov 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be dummy, but if for some reason the user deletes all the lines there is an error here

Suggested change
return self.item_ids[0].repair_id.action_view_scrap_transfers()
if self.item_ids:
return self.item_ids[0].repair_id.action_view_scrap_transfers()

AaronHForgeFlow
AaronHForgeFlow approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional + code review. LGTM

DavidJForgeFlow
DavidJForgeFlow approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@DavidJForgeFlow DavidJForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

MiquelRForgeFlow
MiquelRForgeFlow approved these changes Jan 11, 2024
View reviewed changes
repair_scrap/wizards/repair_scrap_view.xml Outdated
@@ -0,0 +1,66 @@
<?xml version="1.0" ?>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<?xml version="1.0" ?>
<?xml version="1.0" encoding="utf-8"?>

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thank you

repair_scrap/__manifest__.py
@@ -0,0 +1,21 @@
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
# Copyright 2024 ForgeFlow S.L. (http://www.forgeflow.com)
{

in main python files

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thank you

repair_scrap/__manifest__.py Outdated
"version": "15.0.1.0.0",
"license": "AGPL-3",
"category": "Repair",
"summary": """Repair Scrap""",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"summary": """Repair Scrap""",
"summary": "To send to scrap components or irreparable components.",

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@LoisRForgeFlow
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-37-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit bd0bd26 into OCA:15.0 Feb 7, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8a037f9. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 15.0-add-repair_scrap branch February 7, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidJForgeFlow DavidJForgeFlow DavidJForgeFlow approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ThiagoMForgeFlow @OCA-git-bot @LoisRForgeFlow @AaronHForgeFlow @MiquelRForgeFlow @DavidJForgeFlow