[16.0][MIG] repair_reinvoice: Migration to 16.0 #25
Conversation
PauBForgeFlow
force-pushed
the
16.0-mig-repair_reinvoice
branch
from
67f19d9 to
1199dbe
Compare
PauBForgeFlow
force-pushed
the
16.0-mig-repair_reinvoice
branch
from
1199dbe to
d279d1c
Compare
There was a problem hiding this comment.
I have been testing it on Runboat, and it doesn't seem to be working properly yet.
I've created the Repair Order, confirmed it, started and finished it. I've created an Invoice, created a Reverse Invoice (both invoices with confirmed payment), and the option to create a new Invoice doesn't show up again.
PauBForgeFlow
force-pushed
the
16.0-mig-repair_reinvoice
branch
from
d279d1c to
f8a329e
Compare
|
/ocabot migration repair_reinvoice |
|
On my way to merge this fine PR! |
|
@LoisRForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-25-by-LoisRForgeFlow-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
| @@ -52,6 +52,7 @@ def _create_invoices(self, group=False): | |||
| for repair_id in repair_dict: | |||
| repair = self.env["repair.order"].browse(repair_id) | |||
| repair.invoice_ids += repair.invoice_id | |||
| return | |||
There was a problem hiding this comment.
I just aborted the merge, you need to return the repair_dict here.
|
@PauBForgeFlow could you attend my last comment? Thanks! |
PauBForgeFlow
force-pushed
the
16.0-mig-repair_reinvoice
branch
from
f8a329e to
9b416a7
Compare
|
Thanks! /ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 84b8cd7. Thanks a lot for contributing to OCA. ❤️ |
No description provided.