Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] pos_auto_invoice_default_partner #1259

Closed

Conversation

huguesdk
Copy link
Member

compatibility layer between pos_auto_invoice and pos_default_partner.

depends on #1258.

Copy link

@polchampion polchampion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsuccessful functional test on rotor-v16-test

I still have the error "please select the customer" when trying to validate a payment without a customer

@polchampion
Copy link

unsuccessful functional test on rotor-v16-test

I still have the error "please select the customer" when trying to validate a payment without a customer

This accidental behaviour is preferable to the v12 way, because accounting-wise it should not be a default option to create invoices for a default customer when no customer is manually selected. It's also more logical, and there is no use case needing the old behaviour.

@huguesdk Does this module do anything then ? If we remove the part of the code that isn't used, is there something left in this module ?

@huguesdk
Copy link
Member Author

@polchampion yes it does, but it doesn’t work if pos_loyalty is also installed. i fixed that, but it makes more sense to implement it directly in pos_default_partner, so i did it there: #1276.

@huguesdk huguesdk closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants