Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] pos_user_restriction #1256

Merged
merged 20 commits into from
Dec 27, 2024

Conversation

em230418
Copy link
Contributor

No description provided.

eLBati and others added 20 commits October 25, 2024 08:54
Restrict some users to only access their assigned points of sale
Currently translated at 100.0% (7 of 7 strings)

Translation: pos-12.0/pos-12.0-pos_user_restriction
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_user_restriction/es/
Updated roadmap description
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-15.0/pos-15.0-pos_user_restriction
Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_user_restriction/
Currently translated at 100.0% (11 of 11 strings)

Translation: pos-15.0/pos-15.0-pos_user_restriction
Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_user_restriction/it/
Currently translated at 100.0% (11 of 11 strings)

Translation: pos-15.0/pos-15.0-pos_user_restriction
Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_user_restriction/es/
Migration notes:

1. Removed bypassing group check, since set_cashbox_pos in 16.0+
does not call has_groups method [1]

2. Removed hack in res_users.py, which should not be the case,
since in res.users' write method has_group is replaced with
_is_internal [2]

3. Removed several ir.model.access records for removed models:

- account.bank.statement.cashbox [3]
- account.cashbox.line [3]
- cash.box.out [4]

[1] odoo/odoo#113151
[2] odoo/odoo@dae28c4#diff-16e37db365c1ea1f2e6c79aeb60c80f68f1a5c75970e8e3f198eb18af56278dd
[3] odoo/odoo@4fb0933
[4] odoo/odoo@7e23eda

In this commit we remove bypassing group check
@Abimael1321
Copy link

LGTM!

Copy link

@Daniel-Melian Daniel-Melian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally reviewed. LGTM.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@hbrunn
Copy link
Member

hbrunn commented Dec 27, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1256-by-hbrunn-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 27, 2024
Signed-off-by hbrunn
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 17.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 17.0-ocabot-merge-pr-1256-by-hbrunn-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7ccae6e into OCA:17.0 Dec 27, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1a54fa3. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.