Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] When migrating code, automatically apply PEP 3135 #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[IMP] When migrating code, automatically apply PEP 3135 #77

wants to merge 1 commit into from

Conversation

anothingguy
Copy link

automatically apply PEP 3135

Example:
super(TestHrEmployee, self).setUp() -> super().setUp()

legalsylvain
legalsylvain reviewed Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

Could you add tests ?

@anothingguy
Copy link
Author

Thanks !

Could you add tests ?

yes, sure

@sbidoul
Copy link
Member

sbidoul commented Oct 28, 2023

I would suggest to delegate this kind of standard python stuff to common python tools such as pyupgrade or ruff (rule UP008).

@trisdoan trisdoan mentioned this pull request Dec 5, 2024
Merged
@trisdoan
Copy link

trisdoan commented Dec 5, 2024

Hello @sbidoul, I implemented your suggestion in OCA/oca-addons-repo-template#288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legalsylvain legalsylvain legalsylvain left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anothingguy @sbidoul @trisdoan @legalsylvain