Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] slugify deprecation #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xaviedoanhduy
Copy link

[IMP] base: promote slugify and slugify_one to base: https://github.com/odoo/odoo/pull/175041/commits/7c426470f37fa3efefbc37e45f0f6065160cc35d

Copy link
Collaborator

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test files are too complex imo. The objective is just to test if replacement is OK

  • no need to write extra code.
  • no need to créate specific files

Otherwise, lgtm. Thanks !

@xaviedoanhduy xaviedoanhduy force-pushed the slugify-deprecation branch 2 times, most recently from d1d4323 to 044f896 Compare October 24, 2024 09:33
@xaviedoanhduy
Copy link
Author

xaviedoanhduy commented Oct 24, 2024

The test files are too complex imo. The objective is just to test if replacement is OK

  • no need to write extra code.
  • no need to créate specific files

Otherwise, lgtm. Thanks !

hi @legalsylvain, I have updated the PR.

@xaviedoanhduy xaviedoanhduy changed the title [IMG] slugify deprecation [IMP] slugify deprecation Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants