-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] add pylint checkers for translation #289
base: master
Are you sure you want to change the base?
Conversation
9e31ce8
to
2fb10b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A couple of sorting suggestions, nothing required or very critical.
2fb10b3
to
f7c012c
Compare
f7c012c
to
7da32f8
Compare
{%- if odoo_version >= 14 %}, | ||
translation-format-interpolation, | ||
translation-format-truncated, | ||
translation-fstring-interpolation, | ||
translation-not-lazy, | ||
translation-too-few-args, | ||
translation-too-many-args, | ||
translation-unsupported-format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you'll need these changes to make it work fine:
{%- if odoo_version >= 14 %}, | |
translation-format-interpolation, | |
translation-format-truncated, | |
translation-fstring-interpolation, | |
translation-not-lazy, | |
translation-too-few-args, | |
translation-too-many-args, | |
translation-unsupported-format | |
{%- if odoo_version >= 14 %} | |
translation-format-interpolation, | |
translation-format-truncated, | |
translation-fstring-interpolation, | |
translation-not-lazy, | |
translation-too-few-args, | |
translation-too-many-args, | |
translation-unsupported-format, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will break too much existing stuff. Please make it a copier question (default = disabled) so PSC can enable on demand.
Note
This change
translation-format-interpolation
translation-format-truncated
translation-fstring-interpolation
translation-not-lazy
translation-too-few-args
translation-too-many-args
translation-unsupported-format
Result