Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml instead of setup.py #216

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Oct 28, 2023

Add a question to generate pyproject.toml files instead of setup.py.

@sbidoul sbidoul force-pushed the add-pyproject-toml branch 4 times, most recently from 94eacb0 to 4103ba1 Compare October 28, 2023 12:49
@yajo
Copy link
Member

yajo commented Oct 30, 2023

thought: Couldn't we just add this always? IIUC, having a pyproject.toml file based on whool inside the addon dir, and having a setup/ folder based on setuptools-odoo, shouldn't conflict, right? Whool would just be the new official way to install addons, and setuptools-odoo would be deprecated and exist only on older branches.

@carmenbianca
Copy link
Member

I wouldn't do both simultaneously in any case, even if they don't conflict. A single source of truth is more important, and it's far easier to debug problems if you don't also have to divine which package installation method is being used.

But I've not properly reviewed the code, so I may change my mind.

@sbidoul
Copy link
Member Author

sbidoul commented Oct 30, 2023

Yes I chose to have one OR the other because they are sometimes modified manually and we don't want to tell people to modify both in that case.

@sbidoul sbidoul force-pushed the add-pyproject-toml branch from 4103ba1 to 9ba7f58 Compare October 31, 2023 09:23
@sbidoul sbidoul force-pushed the add-pyproject-toml branch from 9ba7f58 to 7b5fc1c Compare November 1, 2023 12:28
@sbidoul sbidoul merged commit 69f3b9a into OCA:master Nov 6, 2023
@sbidoul sbidoul deleted the add-pyproject-toml branch November 6, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants