Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][ADD] mrp_bom_compute_sales_price #1427

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

SMaciasOSI
Copy link

No description provided.

@quentinDupont
Copy link

Hello @SMaciasOSI and thanks for this work
If i understand well the code, your module permits to quickly apply sale price to a product thanks to the sum of the sale price of its BoM Components.
It means that you have BoMs composed of Products that you sale.

In my area (handmade food industry), it's the "opposite", you have BoM composed of Raw materials that you have to buy. So the components don't have sale price but purchase (cost) price.

I don't have issues with your approach but maybe you can describe this precisely in your readme ? 🙂

Here is my pending module that handle cost, sale and margin prices : #1227
What do you think of that ?

@SMaciasOSI
Copy link
Author

Hello @SMaciasOSI and thanks for this work If i understand well the code, your module permits to quickly apply sale price to a product thanks to the sum of the sale price of its BoM Components. It means that you have BoMs composed of Products that you sale.

In my area (handmade food industry), it's the "opposite", you have BoM composed of Raw materials that you have to buy. So the components don't have sale price but purchase (cost) price.

I don't have issues with your approach but maybe you can describe this precisely in your readme ? 🙂

Here is my pending module that handle cost, sale and margin prices : #1227 What do you think of that ?

Hello!

Yes, this module intends to allow the users to set the sales price for the manufactured product based on the components' sales price, which may be sold separately as well.

I've seen your module, it looks very useful, however the use case for this module is different. In this scenario, each specific component, since it can also be sold, has a different sales margin, so the sales margin for the manufactured product can't be extrapolated from the components as easily.

@rvalyi rvalyi changed the title [ADD] mrp_bom_compute_sales_price [17.0][ADD] mrp_bom_compute_sales_price Dec 20, 2024
@quentinDupont
Copy link

quentinDupont commented Dec 20, 2024

Yep ok ! Two modules for two very differents usages ! (don't hesitate to review mine ;-))
It's seems to be quite a draft as you are fixing stuffs
You can ping me when it's ready to review and test :)

@quentinDupont
Copy link

each specific component, since it can also be sold, has a different sales margin, so the sales margin for the manufactured product can't be extrapolated from the components as easily.

However, Manufactured product cost should be the sum of its component as well, with a margin = 0 so its sale price is equal to its cost price.

Do you have example for this use cases so it can be more clear in my mind ?

@SMaciasOSI
Copy link
Author

Yep ok ! Two modules for two very differents usages ! (don't hesitate to review mine ;-)) It's seems to be quite a draft as you are fixing stuffs You can ping me when it's ready to review and test :)

This is ready to be reviewed now

@SMaciasOSI
Copy link
Author

each specific component, since it can also be sold, has a different sales margin, so the sales margin for the manufactured product can't be extrapolated from the components as easily.

However, Manufactured product cost should be the sum of its component as well, with a margin = 0 so its sale price is equal to its cost price.

Do you have example for this use cases so it can be more clear in my mind ?

The scenario is as follows

A manufacturing company sells manufactured products, but can also sell the components they use for manufacturing

Each component has a different sales margin

When manufacturing, the manufactured product can't be sold for less than the combined sales price of its components, but it can be sold for more

When a client sends an RFQ, a quotation engineering department has to evaluate what the sales price of the manufactured product should be. This is where this module comes into play. A BoM is generated by the design department, which is then sent to the quotation engineering folks, whose job is to set the sales price for the designed product.

@SMaciasOSI SMaciasOSI force-pushed the 17.0-add-mrp-bom-compute-sales-price branch from 7646bc2 to aca93de Compare January 13, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants