[18.0][MIG] mail_activity_done: Migration to 18.0 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
have been completed. fixup moment js fixup
Changed property in test to a correct one Changed README Added necessary checks if module does not have an icon Added default value to _original_module
Currently translated at 100.0% (15 of 15 strings) Translation: social-16.0/social-16.0-mail_activity_done Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_activity_done/es/
Currently translated at 100.0% (15 of 15 strings) Translation: social-16.0/social-16.0-mail_activity_done Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_activity_done/it/
Currently translated at 46.6% (7 of 15 strings) Translation: social-16.0/social-16.0-mail_activity_done Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_activity_done/fi/
Currently translated at 60.0% (9 of 15 strings) Translation: social-16.0/social-16.0-mail_activity_done Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_activity_done/fi/
Currently translated at 100.0% (15 of 15 strings) Translation: social-16.0/social-16.0-mail_activity_done Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_activity_done/fi/
Currently translated at 100.0% (15 of 15 strings) Translation: social-16.0/social-16.0-mail_activity_done Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_activity_done/fr/
From [[15.0][FIX] mail_activity_done: Remove broken and apparently unused js file OCA#994](OCA#994)
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_activity_done Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_activity_done/
26 tasks
[MIG] change method name
achulii
force-pushed
the
18.0-mig-mail_activity_done
branch
from
b368e67 to
5ae6a49
Compare
hbrunn
requested changes
Dec 27, 2024
| _inherit = "res.users" | ||
|
|
||
| @api.model | ||
| def _get_activity_groups(self): |
There was a problem hiding this comment.
this has very little to do with what upstream does by now.
Did you check if we need this override at all? Given this is pure ORM, I'd expect things to just work because done activities are nonactive.
| domain=lambda self: [("res_model", "=", self._name), ("active", "=", True)] | ||
| ) | ||
|
|
||
| def read_progress_bar(self, domain, group_by, progress_bar): |
There was a problem hiding this comment.
given upstream has a test for the active flag in read_group, I doubt we need this override. Did you test this?
|
/ocabot migration mail_activity_done |
|
There's no issue in this repo with the title 'Migration to version 18.0' and the milestone 18.0, so not possible to add the comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.