Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] l10n_es_aeat_mod347: Avoid fake quarter amounts trackings #3944

Merged

Conversation

pedrobaeza
Copy link
Member

@pedrobaeza pedrobaeza commented Jan 23, 2025

Due to a ORM glitch, when recomputing 347 partner records, there are tracking messages saying that the quarters amount have changed, which is not really that way, so let's compare before doing the assignation for avoiding it if no real amount change.

imagen

@Tecnativa

The problem seems to not be present in v17.

Due to a ORM glitch, when recomputing 347 partner records, there are
tracking messages saying that the quarters amount have changed, which
is not really that way, so let's compare before doing the assignation
for avoiding it if no real amount change.
@pedrobaeza pedrobaeza added this to the 16.0 milestone Jan 23, 2025
@pedrobaeza
Copy link
Member Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-3944-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 23, 2025
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-3944-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3944-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a13a463 into OCA:16.0 Jan 24, 2025
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7d306bd. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-fix-l10n_es_aeat_mod347-quarters_tracking branch January 24, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants