Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][IMP] Paulistana Status Consulta #3527

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

mileo
Copy link
Member

@mileo mileo commented Dec 5, 2024

Apesar de buscar o retorno do status da consulta o método não atualizava a nota fiscal.

@OCA-git-bot
Copy link
Contributor

Hi @rvalyi, @luismalta, @renatonlima, @gabrielcardoso21,
some modules you are maintaining are being modified, check this out!

@mileo mileo force-pushed the 14.0-imp-paulistana-status-consulta branch from ce3d562 to 138ad37 Compare December 5, 2024 04:56
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@antoniospneto antoniospneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

por mim ok tbm, mas ver que o coverage nessa etapa tá bem baixo

@mileo mileo added the bug label Dec 6, 2024
@mileo mileo force-pushed the 14.0-imp-paulistana-status-consulta branch 5 times, most recently from fa45018 to f71dbad Compare December 6, 2024 19:17
@mileo mileo marked this pull request as draft December 6, 2024 20:38
@mileo mileo force-pushed the 14.0-imp-paulistana-status-consulta branch from f71dbad to 0de7409 Compare January 28, 2025 19:32
@mileo mileo marked this pull request as ready for review January 28, 2025 19:32
@mileo
Copy link
Member Author

mileo commented Jan 28, 2025

Pessoal estou meio sem tempo nos próximos dias, não vou conseguir implementar esse teste nesse momento. Se quiserem fazer este merge desta forma, fiquem a vontade.

@rvalyi
Copy link
Member

rvalyi commented Jan 28, 2025

Botar um teste ficara como tarefa se tiver port para uma versão superior...

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-3527-by-rvalyi-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f876350. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit fea1117 into OCA:14.0 Jan 28, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants