[14.0][FIX][l10n_br_fiscal][l10n_br_account] commercial partner #3383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency only commercial partners are allowed in fiscal documents. However, mixin usage from SO, PO or invoices can have partner_id set to the contact instead. Se using commercial_partner_id in these mixins make them work even in these cases.
Invoices can use a contact in partner_id. But when creating a fiscal document, the commercial_partner_id should be used.
|
O #2849 não resolve o mesmo problema de uma forma mais robusta? |
WesleyOliveira98
force-pushed
the
14.0-fix-commercial_partner_id
branch
2 times, most recently
from
d28f2b0 to
364883c
Compare
|
Acredito que a PR do Magno resolve. Porém, soh fiquei com duvida de como montou esta branch já que montou ontem e tem conflitos.. pegou como origem a 14.0 do repositorio oficial ou pegou a 14.0 do fork tecnico da Escodoo ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuação de #2520
cc: @marcelsavegnago @kaynnan