Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] hr_employee_calendar_planning: Migration to 18.0 #1441

Merged

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Feb 5, 2025

Supersedes #1419

Migration to 18.0

Please @pedrobaeza and @chienandalu can you review it?

@Tecnativa TT54169

pedrobaeza and others added 30 commits February 5, 2025 10:07
This module allows to manage employee working time with profiles by date
intervals.

The profiles are regular working time calendars, but they are treated as
master ones here, allowing you to compose complexes working times by dates.

Under the hook, a unique working time is created for each employee with the
proper composition for not affecting the rest of the functionality linked to
this model.

Installation
============

During the installation of the module, current working times are split by
start/end dates for having consistent data, and the potential new composed
calendar planning is saved instead on the employee.

Configuration
=============

1. Go to *Employees > Employees*.
2. Open or create a new one.
3. On the "Public Information" page, fill the section "Calendar planning" with:

   * Starting date (optional).
   * Ending date (optional).
   * Working time to apply during that date interval.

Known issues / Roadmap
======================

* Add a wizard for generating next year calendar planning based on current one
  in batch.
* Add constraint for avoiding planning lines overlapping.
* Avoid the regeneration of whole private calendars each time a change is
  detected.

[UPD] README.rst
[UPD] Update hr_employee_calendar_planning.pot
Add _description for model hr.employee.calendar to make it pass runbot.

[UPD] Update hr_employee_calendar_planning.pot
[UPD] Update hr_employee_calendar_planning.pot

[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-13.0/hr-13.0-hr_employee_calendar_planning
Translate-URL: https://translation.odoo-community.org/projects/hr-13-0/hr-13-0-hr_employee_calendar_planning/
- On the module init, existing employee calendar leaves should be linked
to the employee's new autocalendar.

hr_employee_calendar_planning 13.0.1.0.1
[UPD] Update hr_employee_calendar_planning.pot

[UPD] README.rst
Translated using Weblate (French)

Currently translated at 94.4% (17 of 18 strings)

Translation: hr-14.0/hr-14.0-hr_employee_calendar_planning
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_calendar_planning/fr/
…r when is related to some employee

[UPD] Update hr_employee_calendar_planning.pot

hr_employee_calendar_planning 14.0.1.0.2

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-14.0/hr-14.0-hr_employee_calendar_planning
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_calendar_planning/
… field in to show only allowed records according to company. Add constraint to prevent change avoid changing the company when the calendar is linked to an employee of another company.

[UPD] Update hr_employee_calendar_planning.pot

hr_employee_calendar_planning 14.0.1.1.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-14.0/hr-14.0-hr_employee_calendar_planning
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_calendar_planning/
…even when calendar is not active.

TT31606

[UPD] Update hr_employee_calendar_planning.pot

[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-14.0/hr-14.0-hr_employee_calendar_planning
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_calendar_planning/
…weeks.

Regenerate automatic calendar correctly when calendars are 2 weeks old (or any of them are 2 weeks old).
TT32425
…r if calendars have been defined in employee creation.

TT32425

[UPD] README.rst
Currently translated at 100.0% (22 of 22 strings)

Translation: hr-14.0/hr-14.0-hr_employee_calendar_planning
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_calendar_planning/ca/
…void create employees without calendar planing.

TT35897
hr_employee_calendar_planning 14.0.1.3.1

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-14.0/hr-14.0-hr_employee_calendar_planning
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_calendar_planning/
Parent is not necessary on context, this returns the next error when you
try to select a calendar planning on the employee:
``Uncaught Error: NameError: name 'parent' is not defined``

hr_employee_calendar_planning 14.0.1.4.0
Translated using Weblate (Spanish (Argentina))

Currently translated at 100.0% (23 of 23 strings)

Translation: hr-14.0/hr-14.0-hr_employee_calendar_planning
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_calendar_planning/es_AR/

hr_employee_calendar_planning 14.0.1.4.1
TT36463

[UPD] Update hr_employee_calendar_planning.pot

[UPD] README.rst
…from employee public form view

TT40038

hr_employee_calendar_planning 15.0.1.1.0
…e loop when creating new employees

hr_employee_calendar_planning 15.0.1.1.1
TT41700

hr_employee_calendar_planning 15.0.1.1.2
When another module was installed with demo data but without testing mode, if the demo data includes some `hr.employee` record, it was impossible to install it after `hr_employee_calendar_planning` was installed.

@moduon MT-1622

hr_employee_calendar_planning 15.0.1.1.3
…loyee button from user

hr_employee_calendar_planning 15.0.1.1.4
jonasbuchholz and others added 11 commits February 5, 2025 10:13
… by linking new leaves to auto-generated calendars on creation
…sheet in employee view

[UPD] Update hr_employee_calendar_planning.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-16.0/hr-16.0-hr_employee_calendar_planning
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_calendar_planning/
Currently translated at 100.0% (24 of 24 strings)

Translation: hr-16.0/hr-16.0-hr_employee_calendar_planning
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_calendar_planning/es/
Currently translated at 100.0% (24 of 24 strings)

Translation: hr-16.0/hr-16.0-hr_employee_calendar_planning
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_calendar_planning/it/
Only create and unlink necessary resource_calendar_leaves

[BOT] post-merge updates
[UPD] Update hr_employee_calendar_planning.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-17.0/hr-17.0-hr_employee_calendar_planning
Translate-URL: https://translation.odoo-community.org/projects/hr-17-0/hr-17-0-hr_employee_calendar_planning/
This test collides with the dms module. In this test an employee is
being created with a name that already exists in another test.
The employee's file directory is created with the name of this employee.
As there is already an employee with that name, there is already a
directory with that name and this is what causes the error. As the
probability of 2 employees with the same name coinciding in the same
company is very small, instead of intervening in the logic for the
creation of the employee's directory, we change the name of the
employee in the test so that it does not cause the error when
executing this module together with dms.
In the hypothetical case of two employees with the same name within
the same company, we would have to resort to using other tools, either
by creating an additional module to modify the logic and add an employee
identifier to the name of the directory.

TT52110

[BOT] post-merge updates
…f hr_contract is installed

TT54640

[BOT] post-merge updates
…th leaves that do not already exist

Example use case:
- Install hr_holidays
- Install hr_employee_calendar_planning

odoo.exceptions.CacheMiss: 'resource.calendar.leaves(44,).resource_id'

odoo.exceptions.MissingError: Record does not exist or has been deleted.
(Record: resource.calendar.leaves(44,), User: 1)

[BOT] post-merge updates
@pedrobaeza
Copy link
Member

/ocabot migration hr_employee_calendar_planning

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Feb 5, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 5, 2025
14 tasks
TT54169

Co-authored-by: HeliconiaSolutions
@victoralmau victoralmau force-pushed the 18.0-mig-hr_employee_calendar_planning branch from 5b0a23f to 0e11752 Compare February 5, 2025 16:03
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected 👍

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1441-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5dcc242. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 7e4535b into OCA:18.0 Feb 5, 2025
7 checks passed
@pedrobaeza pedrobaeza deleted the 18.0-mig-hr_employee_calendar_planning branch February 5, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.