Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] hr_holidays_summary_email: change message if empty summary #151

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][FIX] hr_holidays_summary_email: change message if empty summary #151

wants to merge 1 commit into from

Conversation

MiquelRForgeFlow
Copy link
Contributor

Avoid having a mail with:

Selection_4019

@OCA-git-bot
Copy link
Contributor

Hi @JordiMForgeFlow,
some modules you are maintaining are being modified, check this out!

@JoanSForgeFlow
Copy link

Hi @MiquelRForgeFlow,

Not receiving any emails can also be a bit confusing. How about we mention in the email that no one is on vacation this week?

Thanks!

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 16.0-fix-hr_holidays_summary_email-avoid-empty-summary branch from 31af8fd to a69d197 Compare November 25, 2024 11:01
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 16.0-fix-hr_holidays_summary_email-avoid-empty-summary branch from a69d197 to 8da7814 Compare November 25, 2024 11:01
@MiquelRForgeFlow MiquelRForgeFlow changed the title [16.0][IMP] hr_holidays_summary_email: don't send empty summaries [16.0][FIX] hr_holidays_summary_email: change message if empty summary Nov 25, 2024
@MiquelRForgeFlow
Copy link
Contributor Author

MiquelRForgeFlow commented Nov 25, 2024 •
edited
Loading

Not receiving any emails can also be a bit confusing.

In my opinion, the empty summary is spam haha

How about we mention in the email that no one is on vacation this week?

Done.

GuillemCForgeFlow
GuillemCForgeFlow approved these changes Nov 25, 2024
View reviewed changes
Copy link

@GuillemCForgeFlow GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing changes 👍🏿

cubells
cubells approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@cubells cubells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested.

JoanSForgeFlow
JoanSForgeFlow approved these changes Nov 25, 2024
View reviewed changes
Copy link

@JoanSForgeFlow JoanSForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MiquelRForgeFlow . Looks good to me

AaronHForgeFlow
AaronHForgeFlow approved these changes Nov 27, 2024
View reviewed changes
Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillemCForgeFlow GuillemCForgeFlow GuillemCForgeFlow approved these changes

@JordiMForgeFlow JordiMForgeFlow JordiMForgeFlow approved these changes

@JoanSForgeFlow JoanSForgeFlow JoanSForgeFlow approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@cubells cubells cubells approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MiquelRForgeFlow @OCA-git-bot @JoanSForgeFlow @cubells @AaronHForgeFlow @JordiMForgeFlow @GuillemCForgeFlow