Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD]hr_holidays_cumulative_timeoff: new module #137

Closed
wants to merge 1 commit into from

Conversation

PicchiSeba
Copy link

This new module adds a couple of fields (cumulative_remaining_timeoff, cumulative_used_timeoff) used to help leave administrators and officers understand the amount of reserved leave units at a certain point in time.

@PicchiSeba PicchiSeba force-pushed the 14.0-add-hr_holidays_report branch from 1746c1c to a7d2c71 Compare August 13, 2024 06:59
Copy link

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review:

There is some weirdness when it comes to calculating the new fields.

For example, this is the result

image

for these leaves

image

Also, it'd be best if all the cells in the pivot were filled, since it's cumulative. For example, in the first screenshot, Ronnie Hart doesn't have new parental leaves in September but the pivot should show how many parental leaves he used thus far (from the beginning of time, until September, so including August)

@PicchiSeba PicchiSeba marked this pull request as draft September 23, 2024 13:29
@PicchiSeba PicchiSeba force-pushed the 14.0-add-hr_holidays_report branch from a7d2c71 to 28342db Compare September 24, 2024 13:54
@PicchiSeba PicchiSeba force-pushed the 14.0-add-hr_holidays_report branch from 28342db to a5bc222 Compare September 24, 2024 14:00
@PicchiSeba PicchiSeba closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants