Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] hr_leave_custom_hour_interval: Migration to 17.0 #128

Merged

Conversation

xaviedoanhduy
Copy link
Contributor

@xaviedoanhduy xaviedoanhduy commented Jun 18, 2024

The failing test not related to this module

@xaviedoanhduy xaviedoanhduy mentioned this pull request Jun 18, 2024
4 tasks
@xaviedoanhduy xaviedoanhduy marked this pull request as ready for review June 18, 2024 03:41
@pedrobaeza
Copy link
Member

@victoralmau can you check the failing test?

@juanjosesegui-tecnativa

TT50071

@victoralmau
Copy link
Member

To solve hr_holidays_public test it is only necessary to rebase 17.0, the error was solved at 5770e4b.

@pedrobaeza
Copy link
Member

@xaviedoanhduy can you rebase?

@xaviedoanhduy xaviedoanhduy force-pushed the 17.0-mig-hr_leave_custom_hour_interval branch from db76320 to d2d7841 Compare August 20, 2024 15:57
@xaviedoanhduy
Copy link
Contributor Author

Hello @pedrobaeza and @victoralmau, PR has been rebased, congratulations the test case failed has actually been solved. Thanks for your all support.

@pedrobaeza
Copy link
Member

/ocabot migration hr_leave_custom_hour_interval

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Aug 20, 2024
@xaviedoanhduy xaviedoanhduy force-pushed the 17.0-mig-hr_leave_custom_hour_interval branch from d2d7841 to 49bcc33 Compare August 20, 2024 16:25
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-128-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 775b32f into OCA:17.0 Aug 20, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cb09d4d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants