Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][ADD] hr_holidays_remaining_leaves #127

Closed
wants to merge 20 commits into from
Closed

[17.0][ADD] hr_holidays_remaining_leaves #127

wants to merge 20 commits into from

Conversation

sonhd91
Copy link

@sonhd91 sonhd91 commented Jun 17, 2024 •
edited
Loading

The failing test not related to this module

janikvonrotz and others added 19 commits June 12, 2024 14:19
@janikvonrotz
new module hr_holidays_remaining_leaves
07b3eee
@janikvonrotz
remove css and js from new module
722cd04
@janikvonrotz
set version on new module
5f4c578
@janikvonrotz
hr_holidays_remining_leaves: translate and add display field
81c1277
@janikvonrotz
update readmes
20215c4
@janikvonrotz
fix manifest
9feb00c
@janikvonrotz
update readmes
fa50ff7
@janikvonrotz
[hr_employee_skill] init
08955f7
@janikvonrotz
[hr_holidays_remaining_leaves] init
066d0bd
@janikvonrotz
fix module
7b9e1d0
[hr_holidays_remaining_leaves] remove unit form string
adb64dd
[hr_holidays_remaining_leaves] show current remaining
005f283
[hr_holidays_remaining_leaves] exact calcualtion
42d9aa8
[hr_holidays_remaining_leaves] fix
ccb6ecc
@janikvonrotz
[hr_employee_skill] migrate
b9b026c
@janikvonrotz
[hr_employee_attendance_report] migrate
8200c62 
[hr_holidays_remaining_leaves] migrate
@janikvonrotz
update code linting tools
aadd328
@janikvonrotz
all: lint modules
9067114
[IMP] hr_holidays_remaining_leaves: pre-commit auto fixes
ac28cc7
@sonhd91 sonhd91 changed the title [ADD][17.0] hr_holidays_remanining_leaves [ADD][17.0] hr_holidays_remaining_leaves Jun 17, 2024
@sonhd91 sonhd91 force-pushed the 17.0-hr_holidays_remanining_leaves branch 3 times, most recently from 127fcf0 to 0ed9a74 Compare June 17, 2024 08:12
@sonhd91 sonhd91 force-pushed the 17.0-hr_holidays_remanining_leaves branch from 0ed9a74 to dc9e1cb Compare June 17, 2024 08:23
@sonhd91 sonhd91 mentioned this pull request Jun 17, 2024
Closed
@sonhd91 sonhd91 changed the title [ADD][17.0] hr_holidays_remaining_leaves [17.0][ADD] hr_holidays_remaining_leaves Jun 27, 2024
@victorvermot
Copy link

@sonhd91 Could you please rebase this pr to fix conflicts ? Thanks

@pedrobaeza
Copy link
Member

Please avoid plural in the last name (hr_holidays should be kept as upstream module has the plural): https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#modules

@xaviedoanhduy xaviedoanhduy mentioned this pull request Aug 22, 2024
Open
@xaviedoanhduy
Copy link
Contributor

xaviedoanhduy commented Aug 22, 2024 •
edited
Loading

Hello guys, the PR has been rebased in #139

@xaviedoanhduy xaviedoanhduy mentioned this pull request Aug 22, 2024
Open
@pedrobaeza pedrobaeza added this to the 17.0 milestone Aug 22, 2024
@pedrobaeza pedrobaeza closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemannd leemannd leemannd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sonhd91 @victorvermot @pedrobaeza @xaviedoanhduy @leemannd @janikvonrotz