Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][IMP] hr_holidays_credit: add unit in form selection widget & plurals management #124

Merged
merged 1 commit into from
Jun 5, 2024
Merged

[13.0][IMP] hr_holidays_credit: add unit in form selection widget & plurals management #124

merged 1 commit into from
Jun 5, 2024

Conversation

maisim
Copy link

@maisim maisim commented Jun 5, 2024

port from 12.0

OCA/hr#1356

@maisim maisim changed the title [IMP] hr_holidays_credit: add unit in form selection widget & plurals management [13.0][IMP] hr_holidays_credit: add unit in form selection widget & plurals management Jun 5, 2024
@maisim maisim marked this pull request as draft June 5, 2024 09:27
@maisim maisim marked this pull request as ready for review June 5, 2024 10:25
@maisim
Copy link
Author

maisim commented Jun 5, 2024

Hi @alexey-pelykh !

I ported the module by hand because the repo change is not managed by oca-port.

Hi tested functionalities from the runboat build, all seems ok.

I don't know why the test fail on init.py has it is not modified in the PR

Can you have a look ? Thanks a lot !

@alexey-pelykh
Copy link
Contributor

@maisim please don't forget to do the pre-commit run -a :) other than that looks good

@maisim maisim force-pushed the 13.0_hr_holidays_credit_add_unit_in_form_selection_widget branch from 792ccc8 to 16cd7ec Compare June 5, 2024 11:51
alexey-pelykh
alexey-pelykh approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@alexey-pelykh alexey-pelykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexey-pelykh
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-124-by-alexey-pelykh-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 557f2a5 into OCA:13.0 Jun 5, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 769f4f5. Thanks a lot for contributing to OCA. ❤️

@maisim maisim mentioned this pull request Jun 5, 2024
Closed
@maisim
Copy link
Author

maisim commented Jun 5, 2024

I ported the module by hand because the repo change is not managed by oca-por

I discover that oca-port is now able to manage the port even it the repo ha changed \o/

https://github.com/OCA/oca-port#using

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-pelykh alexey-pelykh alexey-pelykh approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maisim @alexey-pelykh @OCA-git-bot