Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test hr_holidays_calendar_event_privacy separately #106

Conversation

gurneyalex
Copy link
Member

The tests on the 15.0 branch are broken because of a failing test in hr_holidays_calendar_event_privacy. This looks like a bad interaction with another module so I'm moving the testing of hr_holidays_calendar_event_privacy to a separate batch.

Done as part of an update of the copier template

done as part of an update of the copier template
@pedrobaeza
Copy link
Member

Duplicate the builds is not good. What is the error and can't it be prevented other way (for example, just detecting if config["test_enable"] and without a specific context for disabling the incompatible behavior if not testing the own module)?

@pedrobaeza pedrobaeza added this to the 15.0 milestone Feb 5, 2024
@gurneyalex
Copy link
Member Author

@pedrobaeza the error on the 15.0 branch is https://github.com/OCA/hr-holidays/actions/runs/7276826929/job/19827470569#step:8:37 which is different from the one I get on this build.

I'll check with @grindtildeath about the failure

@gurneyalex
Copy link
Member Author

The tests were green when the last merge on the branch was made on Dec 9, 2023, and started failing on a translation commit on Dec. 20, 2023. So the cause if the red CI is not on the module I'm splitting, but likely in a dependency or in an change in Odoo :-(

I'm closing this PR, and will dig a bit deeper later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants