[18.0][MIG] helpdesk_mgmt: Migration to 18.0 #676
Conversation
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/
Currently translated at 100.0% (216 of 216 strings) Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/es_AR/
This helps to really prioritize tickets as they will show on the top of the list or kanban. It is also more aligned with standard project tasks.
Currently translated at 4.1% (9 of 216 strings) Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/pl/
…(before, the total was filtered by those of the user's partner, but all the ones to which the user had access were shown in the list). TT38426
…y company (if set) or the user's default company. TT38426
Currently translated at 5.5% (12 of 216 strings) Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/pl/
When the user has no access rights the `search` call returns an AccessError. TT38713
Replace _prepare_portal_layout_values to _prepare_home_portal_values function. TT38713
Fix OCA#374 - Odoo expects `fr.po` for French translations, not `fr_FR.po`.
This is a start to increase coverage; not exhaustive yet.
Bring 15.0 ticket list & form views shown in portal mode in line with those defined in the "project" module to display tasks. While most elements remain the same, this cset also adds: * List: group-by & search filters. * Form: close date, assigned user, attachments.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/
Currently translated at 90.7% (207 of 228 strings) Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/fr/
on tickets submitted from the portal. Rely on `plaintext2html`, same as Odoo in its controller for message threads (`/odoo15/addons/portal/controllers/mail.py`). Existing portal test adapted to check this.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: helpdesk-17.0/helpdesk-17.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-17-0/helpdesk-17-0-helpdesk_mgmt/
Currently translated at 100.0% (254 of 254 strings) Translation: helpdesk-17.0/helpdesk-17.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-17-0/helpdesk-17-0-helpdesk_mgmt/it/
Currently translated at 100.0% (254 of 254 strings) Translation: helpdesk-17.0/helpdesk-17.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-17-0/helpdesk-17-0-helpdesk_mgmt/it/
…mail Forward port of fcf0a41
|
Could you review this migration PR? |
There was a problem hiding this comment.
Hi @kobros-tech good job, fine by me both codewise & functional tests
I tested new ticket from portal then communication with backend through mail thread + adding attachment; it's all good!
|
I get this error when trying to navigate to the form by searching: I can get to the other views though. |
when there are not any tickets yet there is just this odd button. |
|
could you tell me what happened exactly to get this error, I also need the full url link? |
|
Please, cherry-pick #683 to commit history (before migration and pre-commit commits) |
|
@victoralmau is this correct? |
|
Please, cherry-pick 8e2d92a to commit history (before migration and pre-commit commits) |
If a migration PR of the module already exists, do not create a new one. |
|
Please, cherry-pick #687 to commit history (before migration and pre-commit commits) |
|
Please, cherry-pick #688 to commit history (before migration and pre-commit commits) |
kobros-tech
force-pushed
the
18.0-mig-helpdesk_mgmt
branch
from
7efa61e to
97606b2
Compare
|
@victoralmau all merged commits are here now, can we merge this PR before we get a new commit merged again :) |
There was a problem hiding this comment.
Code and functional review:
As stated in the migration guide “You can replace the call to translate a string () with self.env._ for getting some performance improvement in some cases._” there should be changes in this regard.
Other less important comments
- I don't understand the reason for adding/complete translations, IMO that will only be done by the bot when the PR is merged and the .po files are updated.
- The indentation changes are confusing, although perhaps this cannot be changed.
kobros-tech
force-pushed
the
18.0-mig-helpdesk_mgmt
branch
from
97606b2 to
3c84c68
Compare
kobros-tech
force-pushed
the
18.0-mig-helpdesk_mgmt
branch
from
3c84c68 to
20b9294
Compare
kobros-tech
force-pushed
the
18.0-mig-helpdesk_mgmt
branch
from
ffe5d81 to
7e468b9
Compare
this PR is just a fixing to PR #664 which needed to update the images, kanban card content, and kanban menu content