Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][IMP] fieldservice_stock: Compute move_ids from related pickings #1296

Merged
merged 1 commit into from
Jan 21, 2025
Merged

[15.0][IMP] fieldservice_stock: Compute move_ids from related pickings #1296

merged 1 commit into from
Jan 21, 2025

Conversation

ppyczko
Copy link

@ppyczko ppyczko commented Jan 14, 2025 •
edited
Loading

When linking a stock picking with an FSM order, the move_ids in the Inventory tab of the related FSM order are not displayed. This IMP aims to compute these move_ids directly from the associated pickings.

cc https://github.com/APSL 165722

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @BernatObrador please review

@OCA-git-bot
Copy link
Contributor

Hi @max3903, @smangukiya, @wolfhall, @brian10048,
some modules you are maintaining are being modified, check this out!

@ppyczko ppyczko changed the title [IMP] fieldservice_stock: Compute move_ids from related pickings [15.0][IMP] fieldservice_stock: Compute move_ids from related pickings Jan 14, 2025
@ppyczko ppyczko marked this pull request as ready for review January 14, 2025 15:22
peluko00
peluko00 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Code review and tested in runboat

BernatObrador
BernatObrador approved these changes Jan 15, 2025
View reviewed changes
Copy link

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mpascuall
mpascuall approved these changes Jan 15, 2025
View reviewed changes
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ppyczko
Copy link
Author

ppyczko commented Jan 21, 2025

Hi @max3903, could you review if this is ready to merge when you have a moment please? Thank you!

@max3903 max3903 added this to the 15.0 milestone Jan 21, 2025
@max3903 max3903 added the bug label Jan 21, 2025
@max3903 max3903 self-assigned this Jan 21, 2025
@max3903
Copy link
Member

max3903 commented Jan 21, 2025

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1296-by-max3903-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 380c2b4 into OCA:15.0 Jan 21, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cbcc326. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpascuall mpascuall mpascuall approved these changes

@BernatObrador BernatObrador BernatObrador approved these changes

@peluko00 peluko00 peluko00 approved these changes

@max3903 max3903 max3903 approved these changes

Assignees

@max3903 max3903

Labels
approved bug merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ppyczko @OCA-git-bot @max3903 @peluko00 @BernatObrador @mpascuall