Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] base_edifact: improve method map2odoo_product to take pia segment into account #990

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

trisdoan
Copy link
Contributor

@trisdoan trisdoan commented Jun 10, 2024

This change

  • Improve map2odoo_product() to process pia segment (if provided). The codes is later used to find products in business.document.import:_match_product_search()
  • Before this change, users cannot import sale order when barcode and product code are both provided in edifact file and product,in Odoo, does not contain barcode.

Result

  1. Import with non-existing code
    user_error

  2. Import with skipping error
    chatter_log

@pedrobaeza pedrobaeza added this to the 16.0 milestone Jun 10, 2024
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@cyrilmanuel
Copy link
Contributor

Hiii @simahawk all good for you ?

@simahawk
Copy link
Contributor

simahawk commented Jul 3, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-990-by-simahawk-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 096c7b3 into OCA:16.0 Jul 3, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 20ba506. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants