Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] punchout modules #937

Open
wants to merge 8 commits into
base: 16.0
Choose a base branch
from

Conversation

benwillig
Copy link

Based on #817

@benwillig benwillig force-pushed the 16.0-mig_punchout-bwi branch from a95defc to b30be1d Compare February 16, 2024 08:05
@bosd
Copy link
Contributor

bosd commented May 27, 2024

Can you please split the isort,prettier commit from the migration commit?
It makes review a bit easier.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted

@alexbottemanne alexbottemanne force-pushed the 16.0-mig_punchout-bwi branch 2 times, most recently from 00022e6 to 2da16ea Compare May 29, 2024 13:55
@benwillig benwillig force-pushed the 16.0-mig_punchout-bwi branch from 2da16ea to 60c9542 Compare May 30, 2024 09:20
@benwillig
Copy link
Author

Can you please split the isort,prettier commit from the migration commit? It makes review a bit easier.

I won't do it for this PR as the changes are not that huge, but I will keep it in mind for my next PRs.

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 29, 2024
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants