-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] base_ubl: street3 in UBL generation #904
Conversation
a317f31
to
c41829a
Compare
streetname.text = partner.street | ||
if partner.street2: | ||
streetname.text = partner.street or partner.street2 | ||
if partner.street and partner.street2: | ||
addstreetname = etree.SubElement( | ||
address, ns["cbc"] + "AdditionalStreetName" | ||
) | ||
addstreetname.text = partner.street2 | ||
if hasattr(partner, "street3") and partner.street3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if hasattr(partner, "street3") and partner.street3: | |
# if oca/partner-contact/partner_address_street3 is installed | |
if hasattr(partner, "street3") and partner.street3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment added
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
In an address, the real street is usually put on the last "street" field. Ensure we get this in StreetName or AdditionalStreetName but not in another element. Example: - name: Ms H Williams - street: Finance and Accounting - street2: Australia Post - street3: 219–241 Cleveland St
c41829a
to
38d876e
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
In an address, the real street is usually put on the last "street" field. Ensure we get this in StreetName or AdditionalStreetName but not in another element.
Example from https://en.wikipedia.org/wiki/Address
Also improve UBL generation in case one of the street field is empty
cc @simahawk @nilshamerlinck