Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] account_invoice_export #890

Merged
merged 26 commits into from
Jul 12, 2024

Conversation

TDu
Copy link
Member

@TDu TDu commented Dec 14, 2023

Along with the migration, I split the module to make the dependency on queue job optional. See commits for details.

TDu and others added 24 commits November 22, 2023 16:02
Refactor to help integration by other module.
An example is on l10n_switzerland/ebill_paynet.
This change the visibility of the send eBill button on the invoice.
It is now only shown if the option is checked on the transmit method.
Also improve the configuration on the transmit method adding
information on the process.
When the ebill was resend the job was executed but nothing was sent.
Add the option to customize the url used to export dynamically.
This `invoice_send` field does not exist (anymore ?)
The resend button was not displayed when needed.
Looks like some parts of a commit on 13 missing.
Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixup to squash, LG

Copy link

@grindtildeath grindtildeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI to fix but LG

account_invoice_export/models/account_move.py Outdated Show resolved Hide resolved
account_invoice_export/tests/common.py Show resolved Hide resolved
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 12, 2024
@TDu TDu force-pushed the 16.0-mig-account_invoice_export branch from 982c3d6 to ebf8d24 Compare May 31, 2024 08:44
@TDu TDu force-pushed the 16.0-mig-account_invoice_export branch from e7fc185 to f89f258 Compare May 31, 2024 09:11
TDu added 2 commits May 31, 2024 13:12
This is a refactor of `account_invoice_export` to make optional the dependency
on queue job.
Which can be installed with the new module.
@TDu TDu force-pushed the 16.0-mig-account_invoice_export branch from f89f258 to 0fdc7f1 Compare May 31, 2024 11:12
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 2, 2024
@TDu
Copy link
Member Author

TDu commented Jun 14, 2024

@simahawk This one is ready to be merged IMO

@simahawk
Copy link
Contributor

/ocabot migration account_invoice_export
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 12, 2024
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-890-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Jul 12, 2024
18 tasks
@OCA-git-bot OCA-git-bot merged commit aa38cf1 into OCA:16.0 Jul 12, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 577da23. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants