[16.0][MIG] sale_order_import_edifact: Migration to 16.0 #821

QuocDuong1306 · 2023-09-28T09:28:18Z

Depends on:

nilshamerlinck · 2023-10-02T11:01:14Z

Note:

sale_order_import_edifact is now just bringing EDIFACT support to sale_order_import, disconnected from the EDI framework
it's edi_sale_edifact_oca, similarily to edi_sale_ubl_oca, that will glue sale_order_import_edifact with the EDI framework from now on

simahawk · 2023-10-02T15:07:28Z

sale_order_import_edifact/wizard/sale_order_import.py

+
+    @api.onchange("order_file")
+    def order_file_change(self):
+        if self.edifact_ok:


see my comments on #816

I don't understand this. We should leverage the call to super for loading defaults.
Also, here, the doc_type and the price_source are kind of hardcoded...
Shouldn't we rely on the parsing of the file as for the other formats?

This is to be able to force from configuration.

sale_order_import: price_source: order confirm_order: false wiz_ctx: file_ext: 'edi' release: 'd96a' doc_type: 'rfq'

but yes, price_source should be taken from context like doc_type

that's the point. Instead of having special keys, we can rely on the fact that defaults will be taken automatically.
In they yml example above I'd like to get rid of the special keys price_source and confirm_order.
In the wiz ctx we should see something like:

wiz_ctx: default_file_ext: edi default_release: d96a default_doc_type: rfq default_price_source: order default_confirm_order: true

and if I'm not mistaken the only field missing here is confirm_order which I'd like to add as a boolean in the sale.order.import wizard to automatically confirm it instead for relying on a custom machinery in edi_sale_oca.
TBH is my "fault". Is something that I didn't introduce in v 14 and now I'd like to clear it up.
Hope is clear 😉

I created a PR for confirm_order field in sale_order_import module at #839
Could you have a look?

FTR OCA/edi-framework#31 (comment)

QuocDuong1306 · 2023-10-11T04:41:26Z

Hi @simahawk , I updated

sale_order_import_edifact/readme/ROADMAP.rst

sale_order_import_edifact/tests/test_edifact_order_import.py

sale_order_import_edifact/wizard/sale_order_import.py

simahawk · 2023-10-17T08:26:58Z

sale_order_import_edifact/wizard/sale_order_import.py

+
+    @api.onchange("order_file")
+    def order_file_change(self):
+        if self.edifact_ok:


I don't understand this. We should leverage the call to super for loading defaults.
Also, here, the doc_type and the price_source are kind of hardcoded...
Shouldn't we rely on the parsing of the file as for the other formats?

sale_order_import_edifact/wizard/sale_order_import.py

test-requirements.txt

QuocDuong1306 · 2023-10-19T03:47:52Z

I updated, but waiting for your reply to the comments above:

This was an old item that was in the old version, so may I remove it?
This button was added by the original author of the module in v14. So do you want me to remove this button?

After that, I will force push again

sale_order_import_edifact/wizard/sale_order_import.py

sale_order_import_edifact/__manifest__.py

simahawk · 2023-10-23T11:59:04Z

sale_order_import_edifact/models/business_document_import.py

+    _inherit = "business.document.import"
+
+    @api.model
+    def _hook_match_partner(self, partner_dict, chatter_msg, domain, order):


matching a partner via gln should be a generic thing... what is really needed here that is specific to edifact?
IMO there's something "wrong" or "too rigid" here

edi/partner_identification_import/models/business_document_import.py

Line 15 in d9309db

schemeIDs = [

whereas it is assumed that the scheme comes from a UBL file...

If you don't have time to solve it now, I would a TODO to refactor that piece of code and drop this one.

CC @jbaudoux

sale_order_import_edifact/readme/ROADMAP.rst

sale_order_import_edifact/wizard/sale_order_import.py

QuocDuong1306 · 2023-10-25T04:21:30Z

I updated

sale_order_import_edifact/__manifest__.py

sale_order_import_edifact/readme/CONTRIBUTORS.rst

sale_order_import_edifact/wizard/sale_order_import.py

simahawk

Almost there! 🦾
Dependencies to drop and small remarks on the doc type.

test-requirements.txt

sale_order_import_edifact/wizard/sale_order_import.py

QuocDuong1306 · 2023-10-26T09:32:08Z

OK @simahawk , done here

simahawk

LG

simahawk · 2023-11-13T12:47:07Z

/ocabot rebase

…vided

…IMD segment

OCA-git-bot · 2023-11-13T12:47:15Z

Congratulations, PR rebased to 16.0.

simahawk · 2023-11-13T12:59:33Z

/ocabot merge nobump

OCA-git-bot · 2023-11-13T12:59:40Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-821-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot · 2023-11-13T13:05:29Z

Congratulations, your PR was merged at 0801b88. Thanks a lot for contributing to OCA. ❤️

QuocDuong1306 force-pushed the 16.0-mig-sale_order_import_edifact branch from 58d1e64 to 1ccab24 Compare September 28, 2023 10:11

simahawk requested changes Oct 2, 2023

View reviewed changes

QuocDuong1306 marked this pull request as draft October 4, 2023 01:29

QuocDuong1306 force-pushed the 16.0-mig-sale_order_import_edifact branch from 1ccab24 to bd5f7b1 Compare October 11, 2023 04:37

QuocDuong1306 requested a review from simahawk October 11, 2023 04:40

QuocDuong1306 marked this pull request as ready for review October 11, 2023 04:40

simahawk requested changes Oct 17, 2023

View reviewed changes

QuocDuong1306 marked this pull request as draft October 18, 2023 07:01

QuocDuong1306 force-pushed the 16.0-mig-sale_order_import_edifact branch 2 times, most recently from 3a201e2 to 652f5cd Compare October 19, 2023 03:36

QuocDuong1306 marked this pull request as ready for review October 19, 2023 03:47

QuocDuong1306 requested a review from simahawk October 19, 2023 03:48

QuocDuong1306 force-pushed the 16.0-mig-sale_order_import_edifact branch from 652f5cd to dcdcad4 Compare October 19, 2023 04:45

yvaucher mentioned this pull request Oct 19, 2023

[16.0][ADD] edi_sale_edifact_oca OCA/edi-framework#32

Merged

simahawk reviewed Oct 19, 2023

View reviewed changes

QuocDuong1306 force-pushed the 16.0-mig-sale_order_import_edifact branch from dcdcad4 to 17ce326 Compare October 20, 2023 03:59

simahawk reviewed Oct 23, 2023

View reviewed changes

QuocDuong1306 force-pushed the 16.0-mig-sale_order_import_edifact branch from 17ce326 to 901edc5 Compare October 25, 2023 04:17

simahawk reviewed Oct 25, 2023

View reviewed changes

QuocDuong1306 force-pushed the 16.0-mig-sale_order_import_edifact branch from 901edc5 to c3ae082 Compare October 25, 2023 07:59

simahawk reviewed Oct 26, 2023

View reviewed changes

test-requirements.txt Outdated Show resolved Hide resolved

sale_order_import_edifact/wizard/sale_order_import.py Outdated Show resolved Hide resolved

sale_order_import_edifact/wizard/sale_order_import.py Outdated Show resolved Hide resolved

QuocDuong1306 force-pushed the 16.0-mig-sale_order_import_edifact branch from 1c31f90 to 204efcd Compare October 26, 2023 09:25

QuocDuong1306 force-pushed the 16.0-mig-sale_order_import_edifact branch 2 times, most recently from 3bd9ed1 to c251cc1 Compare October 27, 2023 03:06

QuocDuong1306 requested a review from simahawk October 27, 2023 07:51

simahawk approved these changes Oct 30, 2023

View reviewed changes

rmorant mentioned this pull request Nov 2, 2023

[14.0][ADD] sale_order_import_edifact & base_edifact #779

Closed

rmorant added a commit to rmorant/edi that referenced this pull request Nov 9, 2023

[14.0][BKP] sale_order_import_edifact backport from OCA#821

f4531cc

rmorant mentioned this pull request Nov 9, 2023

[14.0][BKP] sale_order_import_edifact backport from PR 821 v16 #859

Closed

rmorant and others added 13 commits November 13, 2023 12:47

[14.0][MIG] sale_order_import_edifact & base_edifact

fd17474

[FIX] base_edifact: test chore

d62038b

[IMP] sale_order_import_edifact: pre-commit stuff

aa22ea3

[MIG] sale_order_import_edifact: Migration to 16.0

0d867a5

[FIX] sale_order_import_edifact: Allow files without vat

1ed75fa

[FIX] sale_order_import_edifact: fix get quantity form QTY segment

9132a03

[FIX] sale_order_import_edifact: fix problem product price is not pro…

69443ba

…vided

[IMP] sale_order_import_edifact: Fallback on PIA (SA) when LIN is empty

116ffae

[IMP] sale_order_import_edifact: support get product desciption from …

880c4a1

…IMD segment

[IMP] sale_order_import_edifact: add new data demo

0facfa5

[IMP] sale_order_import_edifact: add testcase for no ean in LIN segment

f796b06

[IMP] sale_order_import_edifact: add testcase for no PRI segment

a5efa96

[IMP] sale_order_import_edifact: support EDI files with no extension

a22cf47

OCA-git-bot force-pushed the 16.0-mig-sale_order_import_edifact branch from c251cc1 to a22cf47 Compare November 13, 2023 12:47

OCA-git-bot added the bot is merging ⏳ label Nov 13, 2023

OCA-git-bot merged commit 05af771 into OCA:16.0 Nov 13, 2023
6 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] sale_order_import_edifact: Migration to 16.0 #821

[16.0][MIG] sale_order_import_edifact: Migration to 16.0 #821

QuocDuong1306 commented Sep 28, 2023 •

edited by simahawk

Loading

nilshamerlinck commented Oct 2, 2023

simahawk Oct 2, 2023

simahawk Oct 17, 2023

rmorant Oct 19, 2023

simahawk Oct 23, 2023

QuocDuong1306 Oct 25, 2023

simahawk Oct 26, 2023

QuocDuong1306 commented Oct 11, 2023

simahawk Oct 17, 2023

QuocDuong1306 commented Oct 19, 2023

simahawk Oct 23, 2023

QuocDuong1306 commented Oct 25, 2023 •

edited

Loading

simahawk left a comment

QuocDuong1306 commented Oct 26, 2023

simahawk left a comment

simahawk commented Nov 13, 2023

OCA-git-bot commented Nov 13, 2023

simahawk commented Nov 13, 2023

OCA-git-bot commented Nov 13, 2023

OCA-git-bot commented Nov 13, 2023

[16.0][MIG] sale_order_import_edifact: Migration to 16.0 #821

[16.0][MIG] sale_order_import_edifact: Migration to 16.0 #821

Conversation

QuocDuong1306 commented Sep 28, 2023 • edited by simahawk Loading

nilshamerlinck commented Oct 2, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

QuocDuong1306 commented Oct 11, 2023

Choose a reason for hiding this comment

QuocDuong1306 commented Oct 19, 2023

Choose a reason for hiding this comment

QuocDuong1306 commented Oct 25, 2023 • edited Loading

simahawk left a comment

Choose a reason for hiding this comment

QuocDuong1306 commented Oct 26, 2023

simahawk left a comment

Choose a reason for hiding this comment

simahawk commented Nov 13, 2023

OCA-git-bot commented Nov 13, 2023

simahawk commented Nov 13, 2023

OCA-git-bot commented Nov 13, 2023

OCA-git-bot commented Nov 13, 2023

QuocDuong1306 commented Sep 28, 2023 •

edited by simahawk

Loading

QuocDuong1306 commented Oct 25, 2023 •

edited

Loading