[16.0][FIX] despatch_advice_import: fix processing

despatch_advice_import/__manifest__.py

@@ -8,7 +8,8 @@
     "version": "16.0.1.2.0",
     "website": "https://github.com/OCA/edi",
     "license": "AGPL-3",
-    "author": "ACSONE SA/NV,Odoo Community Association (OCA)",
+    "author": "ACSONE SA/NV,BCIM,Odoo Community Association (OCA)",
+    "maintainers": ["jbaudoux"],
     "depends": ["purchase", "purchase_stock", "base_business_document_import"],
     "data": ["security/ir.model.access.csv", "wizard/despatch_advice_import.xml"],
     "demo": [],

despatch_advice_import/wizard/despatch_advice_import.py

@@ -1,4 +1,5 @@
 # Copyright 2020 ACSONE SA/NV
+# Copyright 2025 Jacques-Etienne Baudoux (BCIM) <[email protected]>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 import logging
@@ -202,11 +203,19 @@
         self._process_picking_done(lines[0].move_ids[0])
 
     def _process_picking_done(self, move):
-        if all([line.quantity_done != 0 for line in move.picking_id.move_ids]):
-            move.picking_id.button_validate()
-        else:
-            picking = move.picking_id
-            picking.with_context(skip_backorder=True).button_validate()
+        picking = move.picking_id
+        if all(line.state == "cancel" for line in picking.move_ids):
+            return True
+        # skip backorder wizard
+        picking.with_context(
+            skip_immediate=True, skip_backorder=True, skip_sms=True, skip_expired=True
+        ).button_validate()
+
+    def _cancel_extra_moves(self, moves):
+        # Loose dependency with stock_picking_restrict_cancel_printed module
+        # that checks we are canceling the backorder to allow move cancellation.
+        # Mimic odoo setting this cancel_backorder context variable in this case.
+        moves.with_context(cancel_backorder=True)._action_cancel()
 
     def _process_rejected(self, stock_moves, parsed_order_document):
         parsed_order_document["chatter_msg"] = parsed_order_document.get(
@@ -215,8 +224,7 @@
         parsed_order_document["chatter_msg"].append(
             _("Delivery cancelled by the supplier.")
         )
-
-        stock_moves._action_cancel()
+        self._cancel_extra_moves(stock_moves)
 
     def _process_accepted(self, stock_moves, parsed_order_document, forced_qty=False):
         parsed_order_document["chatter_msg"] = (
@@ -296,7 +304,7 @@
         # cancel moves to cancel
         if move_ids_to_cancel:
             moves_to_cancel = self.env["stock.move"].browse(move_ids_to_cancel)
-            moves_to_cancel._action_cancel()
+            self._cancel_extra_moves(moves_to_cancel)
         # move backorder moves to a backorder
         if move_ids_to_backorder:
             moves_to_backorder = self.env["stock.move"].browse(move_ids_to_backorder)