Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] edi_oca: Don't run quick_exec if backend is not active #90

Merged
merged 1 commit into from
Jul 17, 2024
Merged

[16.0][IMP] edi_oca: Don't run quick_exec if backend is not active #90

merged 1 commit into from
Jul 17, 2024

Conversation

HviorForgeFlow
Copy link
Member

Deactivating the backend temporarily disables certain exchange services.

Currently, quick execution does not check whether the backend is active. This PR adds an additional check to ensure that quick_exec is only run when the backend is active.

CC @ForgeFlow

@HviorForgeFlow HviorForgeFlow mentioned this pull request Jun 18, 2024
Merged
@OCA-git-bot
Copy link
Contributor

Hi @etobella, @simahawk,
some modules you are maintaining are being modified, check this out!

@MiquelRForgeFlow
Copy link
Contributor

could you check please @etobella, @simahawk

simahawk
simahawk approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks!
Would you mind porting to 15 and 14 if you have time 🙏 ?

@simahawk
Copy link
Contributor

@HviorForgeFlow that's a fix tho 😉

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the imp-edi_oca-quick_exec-no-backend branch from 6abea97 to 3b019fa Compare July 17, 2024 11:31
This was referenced Jul 17, 2024
Merged
Merged
@MiquelRForgeFlow
Copy link
Contributor

MiquelRForgeFlow commented Jul 17, 2024 •
edited
Loading

@simahawk now it's a fix.

Also:

v12: OCA/edi#998
v14: OCA/edi#1009
v15: OCA/edi#1010

etobella
etobella approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-90-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f920380 into OCA:16.0 Jul 17, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 287aa82. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the imp-edi_oca-quick_exec-no-backend branch July 17, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etobella etobella etobella approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HviorForgeFlow @OCA-git-bot @MiquelRForgeFlow @simahawk @etobella