[16.0][ADD] edi_account_edifact_oca #40
Conversation
QuocDuong1306
force-pushed
the
16.0-add-edi_account_edifact_oca
branch
5 times, most recently
from
c953d00 to
f462621
Compare
| "edi_account_oca", | ||
| "edi_edifact_oca", | ||
| "account_invoice_edifact", | ||
| "edi_storage_oca", |
There was a problem hiding this comment.
This module should not depend on storage. The framework is agnostic for this reason: it does not matter where you send to or receive files from.
| _apply_on = ["account.move"] | ||
|
|
||
| def on_post_account_move(self, move): | ||
| edifact_backend = self.env.ref("edi_edifact_oca.edi_backend_type_edifact") |
There was a problem hiding this comment.
| edifact_backend = self.env.ref("edi_edifact_oca.edi_backend_type_edifact") | |
| backend_type = self.env.ref("edi_edifact_oca.edi_backend_type_edifact") |
| def on_post_account_move(self, move): | ||
| edifact_backend = self.env.ref("edi_edifact_oca.edi_backend_type_edifact") | ||
| if ( | ||
| not move.partner_id |
There was a problem hiding this comment.
pls move this condition to a specific method. The direction is not needed (see the change that I proposed to the field name in the other PR).
| components: | ||
| generate: | ||
| usage: output.generate.account.move | ||
| send: |
QuocDuong1306
force-pushed
the
16.0-add-edi_account_edifact_oca
branch
2 times, most recently
from
e01bee2 to
2b477d4
Compare
|
Hi @simahawk , I updated |
| data = False | ||
| exchange_record = self.exchange_record | ||
| if exchange_record: | ||
| if exchange_record.model == "account.move" and exchange_record.res_id: |
There was a problem hiding this comment.
the model should be selected by _apply_on on the class
| def generate(self): | ||
| data = False | ||
| exchange_record = self.exchange_record | ||
| if exchange_record: |
There was a problem hiding this comment.
I think is impossible to not have an exchange record
| exchange_record = self.exchange_record | ||
| if exchange_record: | ||
| if exchange_record.model == "account.move" and exchange_record.res_id: | ||
| move = self.env["account.move"].browse(exchange_record.res_id) |
There was a problem hiding this comment.
there's no need to browse. Use self.record.
|
|
||
|
|
||
| class EDIExchangeAccountMoveGenerate(Component): | ||
| _name = "edi.output.account.move.generate" |
There was a problem hiding this comment.
| _name = "edi.output.account.move.generate" | |
| _name = "edi.output.edifact.account.move.generate" |
|
|
||
| * Config `ID number` on the customer and the sender. | ||
| * Config `EDI Exchange Type For Invoices` in `Invoicing` tag on the customer. | ||
| * Config `Storage` of the EDI backend. |
There was a problem hiding this comment.
storage is not needed. Is not relevant how you send it.
| exchange_record = self.env["edi.exchange.record"].search( | ||
| [ | ||
| ("model", "=", "account.move"), | ||
| ("res_id", "=", self.invoice.id), | ||
| ] | ||
| ) |
There was a problem hiding this comment.
| exchange_record = self.env["edi.exchange.record"].search( | |
| [ | |
| ("model", "=", "account.move"), | |
| ("res_id", "=", self.invoice.id), | |
| ] | |
| ) | |
| exchange_record = self.invoice.exchange_record_ids[0] |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
QuocDuong1306
force-pushed
the
16.0-add-edi_account_edifact_oca
branch
from
2b477d4 to
f7689fc
Compare
|
Thank @simahawk , the PR has been updated as suggested |
github-actions
bot
removed
the
stale
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
This module supports sending account invoices from EDI channels to the storage system.
Depend on: