Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] crm_project_task: Migration to 17.0 #545

Open
wants to merge 13 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] crm_project_task: Migration to 17.0 #545

wants to merge 13 commits into from

Conversation

mde-scopea
Copy link

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @EmilioPascual,
some modules you are maintaining are being modified, check this out!

@mde-scopea mde-scopea mentioned this pull request Jan 31, 2024
Open
20 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 2, 2024
@EmilioPascual
Copy link
Contributor

@mde-spring can you make rebase to launch runboat again, please? Thank you

@mde-scopea mde-scopea force-pushed the 17.0-mig-crm_project_task branch from de1a8b8 to 063ea54 Compare June 11, 2024 07:03
EmilioPascual
EmilioPascual suggested changes Jun 11, 2024
View reviewed changes
crm_project_task/wizards/crm_create_task.py Outdated
task.message_post(
body=_(
"Task created from lead/opportunity "
"<a href=# data-oe-model=crm.lead data-oe-id=%(lead)d>%(name)s</a>.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link in message post is not working properly
image

crm_project_task/wizards/crm_create_task.py Outdated
self.lead_id.message_post(
body=_(
"Task <a href=# data-oe-model=project.task "
"data-oe-id=%(task)d>%(name)s</a> created.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before
image

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 16, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 20, 2024
@zamberjo
Copy link
Member

Hi @mde-scopea, can you rebase and resolve conflicts?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 3, 2024
@rousseldenis
Copy link

/ocabot migration crm_project_task

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jan 8, 2025
@rousseldenis
Copy link

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@rousseldenis The rebase process failed, because command git rebase origin/17.0 failed with output:

Rebasing (1/13)
Rebasing (2/13)
Rebasing (3/13)
Rebasing (4/13)
Rebasing (5/13)
Rebasing (6/13)
Rebasing (7/13)
Rebasing (8/13)
Rebasing (9/13)
Rebasing (10/13)
Rebasing (11/13)
Rebasing (12/13)
Auto-merging crm_lead_code/static/description/index.html
CONFLICT (content): Merge conflict in crm_lead_code/static/description/index.html
error: could not apply b1f4b85c... [IMP] crm_project_task: pre-commit auto fixes
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply b1f4b85c... [IMP] crm_project_task: pre-commit auto fixes

@rousseldenis
Copy link

@mde-scopea Could you rebase ?

EmilioPascual and others added 11 commits January 15, 2025 08:08
@EmilioPascual @rafaelbn
@yajo @mde-scopea
[15.0][ADD] Module added to create task from lead/opportunities
db9187b 
@moduon MT-3175

Co-authored-by: Rafael Blasco <[email protected]>
Co-authored-by: Jairo Llopis <[email protected]>
@EmilioPascual @mde-scopea
[15.0][ADD] link between lead and task
6eacff1 
- Added field lead_id in task.
- Added field task_ids in lead.
- Added smart button in lead to show related tasks.
@mymage @mde-scopea
Translated using Weblate (Italian)
f813129 
Currently translated at 100.0% (26 of 26 strings)

Translation: crm-15.0/crm-15.0-crm_project_task
Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_project_task/it/
@EmilioPascual @mde-scopea
[IMP] crm_project_task: black, isort, prettier
43a544b
@mde-scopea
[UPD] Update crm_project_task.pot
45273a3
@OCA-git-bot @mde-scopea
[UPD] README.rst
7ae6608
@OCA-git-bot @mde-scopea
crm_project_task 16.0.1.0.1
02c6c8f
@weblate @mde-scopea
Update translation files
cabdbab 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: crm-16.0/crm-16.0-crm_project_task
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_project_task/
@OCA-git-bot @mde-scopea
[UPD] README.rst
ca3cd48
@mde-scopea
Added translation using Weblate (French)
0ec00ac
@mde-scopea
Translated using Weblate (French)
073289d 
Currently translated at 100.0% (26 of 26 strings)

Translation: crm-16.0/crm-16.0-crm_project_task
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_project_task/fr/
@mde-scopea mde-scopea force-pushed the 17.0-mig-crm_project_task branch 2 times, most recently from 0dbda9b to c2e2b30 Compare January 15, 2025 09:05
@mde-scopea
Copy link
Author

@rousseldenis rebase done including fixes on text in the note
Tests failed due to module crm_salesperson_planner

@EmilioPascual
Copy link
Contributor

@rousseldenis rebase done including fixes on text in the note Tests failed due to module crm_salesperson_planner

Errors in chatter messages are still present.
image

image

@mde-scopea mde-scopea force-pushed the 17.0-mig-crm_project_task branch from c2e2b30 to 46c030a Compare January 31, 2025 13:20
@mde-scopea
Copy link
Author

@EmilioPascual sorry, it's fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilioPascual EmilioPascual EmilioPascual requested changes

Assignees
No one assigned
Labels
migration needs review
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
7 participants
@mde-scopea @OCA-git-bot @EmilioPascual @zamberjo @rousseldenis @mymage @weblate