Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] cooperator_documentation #125

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

carmenbianca
Copy link
Member

@carmenbianca carmenbianca commented Apr 5, 2024

Add a link to the Cooperators menu bar.

Capture d’écran du 2024-04-05 12-18-15

Problem: The link points to a French-language page, which isn't ideal.

Internal task: https://gestion.coopiteasy.be/web#id=12257&action=479&model=project.task&view_type=form&menu_id=536

@carmenbianca
Copy link
Member Author

I have found a potential solution to the French-language link. We can create a custom subclass/submodel of ir.actions.act_url which sets the url field to translatable. Because the value of type remains identical, the functionality of the new model will remain intact. See action_service.js in the web module.

But should the creation of such a custom submodel be in a different OCA module? I do not know.

The real correct solution is probably to make the target website language-aware, though. But that obviously isn't always possible.

Copy link
Member

@huguesdk huguesdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some nitpicking from me…

cooperator_documentation/__manifest__.py Outdated Show resolved Hide resolved
cooperator_documentation/__manifest__.py Outdated Show resolved Hide resolved
@victor-champonnois
Copy link
Member

Thank you Carmen for the work!
Maybe we should wait for the documentation to be updated for v16 before deploying.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 11, 2024
@huguesdk huguesdk added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Aug 12, 2024
@huguesdk
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-125-by-huguesdk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit be2116b into OCA:16.0 Sep 25, 2024
4 of 5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b413ada. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved merged 🎉 no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants