Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] fiscal year display #122

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

victor-champonnois
Copy link
Member

No description provided.

@victor-champonnois
Copy link
Member Author

victor-champonnois commented Apr 2, 2024

(don't merge -> it does not work yet actually) fixed

@victor-champonnois victor-champonnois force-pushed the 16.0-fix-fiscal-year-display-1 branch from 949a414 to 7334086 Compare April 2, 2024 14:57
<span t-field="o.declaration_id.fiscal_year" />.
<span
t-field="o.declaration_id.fiscal_year"
t-options-widget="chars"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why sometimes "'chars'" and sometimes "chars"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the widget not be char in any case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, also t-options-widget seems to be deprecated, I used t-options instead.
I tested it and it works.

@carmenbianca carmenbianca self-requested a review April 2, 2024 15:42
@victor-champonnois victor-champonnois force-pushed the 16.0-fix-fiscal-year-display-1 branch from 7334086 to 281e464 Compare April 3, 2024 08:13
@huguesdk huguesdk force-pushed the 16.0-fix-fiscal-year-display-1 branch 2 times, most recently from ca2c81b to 281e464 Compare April 3, 2024 08:47
@huguesdk
Copy link
Member

huguesdk commented Apr 3, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-122-by-huguesdk-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3e9e6e1 into OCA:16.0 Apr 3, 2024
11 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8036237. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants