[REF] l10n_be_cooperator_national_number: Improve method name

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

l10n_be_cooperator_national_number/models/res_partner.py

@@ -36,9 +36,8 @@ def get_be_national_register_number(self):
         return None
 
     @api.model
-    def check_be_national_register_number(self, national_number, error=False):
-        """Verify whether the national number is valid. Returns True if invalid,
-        which is consistent with validate_l10n_be_national_registry_number.
+    def validate_be_national_register_number(self, national_number, error=False):
+        """Verify whether the national number is valid. Returns True if valid.
 
         If error is True, a ValidationError is raised instead.
         """
@@ -52,10 +51,10 @@ def check_be_national_register_number(self, national_number, error=False):
         except ValidationError:
             if error:
                 raise
-            return True
-        return False
+            return False
+        return True
 
-    def update_belgian_national_number(self, national_number):
+    def update_be_national_register_number(self, national_number):
         self.ensure_one()
         result = None
         if national_number:

l10n_be_cooperator_national_number/models/subscription_request.py

@@ -37,13 +37,13 @@ def validate_subscription_request(self):
         if self.require_national_number and not self.national_number:
             raise UserError(_("National Number is required."))
         if self.national_number:
-            self.env["res.partner"].check_be_national_register_number(
+            self.env["res.partner"].validate_be_national_register_number(
                 self.national_number, error=True
             )
         invoice = super().validate_subscription_request()
         if not self.is_company:
             partner = invoice.partner_id
-            partner.update_belgian_national_number(self.national_number)
+            partner.update_be_national_register_number(self.national_number)
         return invoice
 
     def set_person_info(self, partner):

l10n_be_cooperator_national_number/readme/newsfragments/136.misc.1.rst

@@ -1,3 +1,4 @@
 ``check_be_national_register_number`` moved from ``subscription.request`` to
-``res.partner``. Added ``error`` kwarg, and it is no longer necessary to call
-this method with ``sudo()``.
+``res.partner`` and renamed to ``validate_be_national_register_number``. Added
+``error`` kwarg, and it is no longer necessary to call this method with
+``sudo()``.

l10n_be_cooperator_national_number/readme/newsfragments/136.misc.2.rst

@@ -0,0 +1,2 @@
+``update_belgian_national_number`` renamed to
+``update_be_national_register_number``.

l10n_be_cooperator_website_national_number/controllers/main.py

@@ -36,10 +36,10 @@ def _additional_validate(self, kwargs, logged, values, post_file):
             return result
         national_number = values.get("national_number")
         if national_number:
-            failed = request.env["res.partner"].check_be_national_register_number(
+            valid = request.env["res.partner"].validate_be_national_register_number(
                 values["national_number"]
             )
-            if failed:
+            if not valid:
                 values["error_msg"] = (
                     _("%s is not a valid Belgian national registration number")
                     % values["national_number"]