Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] connector: test performance improvement #468

Closed
wants to merge 3 commits into from
Closed

[16.0][IMP] connector: test performance improvement #468

wants to merge 3 commits into from

Conversation

josep-tecnativa
Copy link

cc @Tecnativa TT45458

@josep-tecnativa
[IMP] connector: test performance improvement
4a25322 
- Switch to setUpClass for avoiding repeat the same setup for each test.
- Include context keys for avoiding mail operations overhead.
@josep-tecnativa
[IMP] component_event: test performance improvement
4b5c93b 
- Switch to setUpClass for avoiding repeat the same setup for each test.
- Include context keys for avoiding mail operations overhead.
@josep-tecnativa
[IMP] component: test performance improvement
9835126 
- Switch to setUpClass (if needed) for avoiding repeat the same setup for each test.
- Include context keys for avoiding mail operations overhead.
@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@josep-tecnativa
Copy link
Author

ping @pedrobaeza

@pedrobaeza pedrobaeza added this to the 16.0 milestone Oct 20, 2023
@pedrobaeza pedrobaeza requested a review from simahawk October 20, 2023 08:35
simahawk
simahawk approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor remark

component/tests/common.py
cls.env = cls.env(
context=dict(
cls.env.context,
mail_create_nolog=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't be better to use DISABLE_MAIL_CONTEXT everywhere?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@gurneyalex
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-468-by-gurneyalex-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@gurneyalex your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-468-by-gurneyalex-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 31, 2024
@dreispt
Copy link
Member

dreispt commented Apr 27, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-468-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 27, 2024
@OCA-git-bot
Merge PR #468 into 16.0
d9ced3c 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-468-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 1, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 1, 2024
@github-actions github-actions bot closed this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@chienandalu chienandalu chienandalu approved these changes

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
7 participants
@josep-tecnativa @OCA-git-bot @gurneyalex @dreispt @simahawk @chienandalu @pedrobaeza