[16.0][FIX] account_reconcile_oca: missing this.form_controller #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…here is not always this.form_controller
|
Hi @etobella, |
etobella
approved these changes
Jan 15, 2025
pedrobaeza
approved these changes
Jan 15, 2025
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 95b38bf. Thanks a lot for contributing to OCA. ❤️ |
thomaspaulb
deleted the
16.0-account_reconcile_oca-fix_missing_form_controller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #750
I would think this is the correct solution, because depending on through which route the widget is opened, there is not always
this.form_controller. And if it is not there, then its data also does not need to be saved upon switching between items.