-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [IMP] Show reconcile button even if there no entries for reconciliation through configuration #710
base: 16.0
Are you sure you want to change the base?
Conversation
Hi @etobella, |
3111aee
to
39098b3
Compare
…on through configuration pre-commit fixes pre-commit fixes
39098b3
to
93ab99b
Compare
Instead of a configuration option, I think we should provide a permanent link to "Reconcile" in the 3 dots, and thus, show the button if there are entries to reconcile, and go through the dropdown if not. |
@pedrobaeza , there is already a link for reconcile(the Transactions link does the same thing) in the 3 dots, the idea here is to minimise the number of clicks for the users |
Then I'm not sure to make the base module more complex adding these kind of options. Maybe an extra module where the option is to not install it? @ByteMeAsap what is the reasoning behind wanting to go to the reconcile interface without pending entries? What do you think, @etobella ? |
@pedrobaeza , there are 2 reasons to have this, one being users can use this to create new transactions directly and the other one being allowing them to check already reconciled entries |
OK, what about showing a button "New transaction" instead when no entries pending? Anyway, I would like to have the opinion of @etobella and @JordiBForgeFlow |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Adds a option in the configuration to show reconcile button even if there no entries for reconciliation
If the option is enabled , it will show the reconcile button even if there are no entries to reconcile