Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [IMP] Show reconcile button even if there no entries for reconciliation through configuration #710

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

ByteMeAsap
Copy link
Contributor

@ByteMeAsap ByteMeAsap commented Sep 27, 2024

Adds a option in the configuration to show reconcile button even if there no entries for reconciliation

Configuration Settings

If the option is enabled , it will show the reconcile button even if there are no entries to reconcile

Reconcile Button

@OCA-git-bot
Copy link
Contributor

Hi @etobella,
some modules you are maintaining are being modified, check this out!

@ByteMeAsap ByteMeAsap force-pushed the 16.0-fix-account_reconcile_oca branch from 3111aee to 39098b3 Compare September 27, 2024 06:46
…on through configuration

pre-commit fixes

pre-commit fixes
@ByteMeAsap ByteMeAsap force-pushed the 16.0-fix-account_reconcile_oca branch from 39098b3 to 93ab99b Compare September 27, 2024 06:47
@pedrobaeza
Copy link
Member

Instead of a configuration option, I think we should provide a permanent link to "Reconcile" in the 3 dots, and thus, show the button if there are entries to reconcile, and go through the dropdown if not.

@ByteMeAsap
Copy link
Contributor Author

@pedrobaeza , there is already a link for reconcile(the Transactions link does the same thing) in the 3 dots, the idea here is to minimise the number of clicks for the users

@pedrobaeza
Copy link
Member

Then I'm not sure to make the base module more complex adding these kind of options. Maybe an extra module where the option is to not install it?

@ByteMeAsap what is the reasoning behind wanting to go to the reconcile interface without pending entries?

What do you think, @etobella ?

@ByteMeAsap
Copy link
Contributor Author

@ByteMeAsap what is the reasoning behind wanting to go to the reconcile interface without pending entries?

@pedrobaeza , there are 2 reasons to have this, one being users can use this to create new transactions directly and the other one being allowing them to check already reconciled entries

@pedrobaeza
Copy link
Member

OK, what about showing a button "New transaction" instead when no entries pending?

Anyway, I would like to have the opinion of @etobella and @JordiBForgeFlow

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants