Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP]: account_invoice_section_sale_order add option to always … #1887

Merged

Conversation

victorvermot
Copy link
Contributor

We want to be able to create sections even if only one so is selected when creating the invoice

@victorvermot victorvermot force-pushed the imp-account_invoice_section_sale_order branch from 44c0a62 to faa3278 Compare January 22, 2025 12:32
@StefanRijnhart
Copy link
Member

Tests are fixed in #1888

@victorvermot victorvermot force-pushed the imp-account_invoice_section_sale_order branch from faa3278 to e5ae1e0 Compare January 22, 2025 13:51
@victorvermot
Copy link
Contributor Author

@StefanRijnhart Thanks a lot

@StefanRijnhart
Copy link
Member

@victorvermot A review of that PR would be appreciated.

@MiquelRForgeFlow
Copy link
Contributor

Fix was merged, you can rebase.

@victorvermot victorvermot force-pushed the imp-account_invoice_section_sale_order branch 2 times, most recently from b23dc73 to 494b1bd Compare January 28, 2025 09:04
@victorvermot victorvermot force-pushed the imp-account_invoice_section_sale_order branch from 494b1bd to a54c851 Compare January 28, 2025 09:17
@victorvermot victorvermot force-pushed the imp-account_invoice_section_sale_order branch from a54c851 to 5273df5 Compare January 28, 2025 09:18
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simahawk
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1887-by-simahawk-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 856dbbd into OCA:17.0 Jan 28, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bf2b8c5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants