-
-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [MIG] account_invoice_discount_date #1886
[16.0] [MIG] account_invoice_discount_date #1886
Conversation
58b40d6
to
c7c5455
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review,
LGTM thank you @Shide
/ocabot migration account_invoice_discount_date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 thanks!
/ocabot merge patch
On my way to merge this fine PR! |
Congratulations, your PR was merged at f328c90. Thanks a lot for contributing to OCA. ❤️ |
Migrated partially because in Odoo 16, NOW supports early discount dates via Payment Terms.
Fields on account.move.line are the same, so no need to change so much.
https://www.loom.com/share/917825a405314531b52f18c29414f660?sid=015a99dc-bee6-42c4-bdd7-0d17ebadc8e5
MT-8759 @moduon @yajo @rafaelbn @Gelojr @fcvalgar please reivew if you want :)