Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] account_invoice_discount_date #1886

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

Shide
Copy link
Contributor

@Shide Shide commented Jan 22, 2025

Migrated partially because in Odoo 16, NOW supports early discount dates via Payment Terms.
Fields on account.move.line are the same, so no need to change so much.

  • Changed the way that we can find Term Lines
  • Removed account.move.line code
  • Removed code for some views because Odoo core handle the discount_date field.
  • Changed README to show the real purpose of the module right now.

https://www.loom.com/share/917825a405314531b52f18c29414f660?sid=015a99dc-bee6-42c4-bdd7-0d17ebadc8e5

MT-8759 @moduon @yajo @rafaelbn @Gelojr @fcvalgar please reivew if you want :)

@Shide Shide changed the title [MIG] [16.0] account_invoice_discount_date [16.0] [MIG] account_invoice_discount_date Jan 22, 2025
@Shide Shide force-pushed the 16.0-mig-account_invoice_discount_date branch from 58b40d6 to c7c5455 Compare January 22, 2025 11:50
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Copy link
Member

@edlopen edlopen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. LGTM!

Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review,

LGTM thank you @Shide

@rafaelbn
Copy link
Member

/ocabot migration account_invoice_discount_date

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jan 23, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 23, 2025
65 tasks
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 thanks!

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1886-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f328c90. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit da89490 into OCA:16.0 Jan 23, 2025
7 checks passed
@Shide Shide deleted the 16.0-mig-account_invoice_discount_date branch January 23, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants