[18.0][MIG] account_invoice_fiscal_position_update: Migration to 18.0 #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on, tax mapping could be wrong set
Currently translated at 100,0% (4 of 4 strings) Translation: account-invoicing-11.0/account-invoicing-11.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-account_invoice_fiscal_position_update/nl_NL/
Currently translated at 100,0% (4 of 4 strings) Translation: account-invoicing-11.0/account-invoicing-11.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-account_invoice_fiscal_position_update/de/
Currently translated at 100.0% (4 of 4 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_fiscal_position_update/de/
Currently translated at 100.0% (4 of 4 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_fiscal_position_update/pt_BR/
Currently translated at 100.0% (4 of 4 strings) Translation: account-invoicing-13.0/account-invoicing-13.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_invoice_fiscal_position_update/nl/
Currently translated at 100.0% (4 of 4 strings) Translation: account-invoicing-13.0/account-invoicing-13.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_invoice_fiscal_position_update/es/
…xes after changed
…s without comments or notes.
… taxes when this was changed. Otherwise the taxes are not changed when change the fpos.
Don't create new variant, just use the default one.
Currently translated at 100.0% (6 of 6 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_fiscal_position_update/hr/
Currently translated at 100.0% (6 of 6 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_fiscal_position_update/es/
Currently translated at 100.0% (6 of 6 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_fiscal_position_update/pt_BR/
…fiscal position with a line without product and description
|
LGTM |
cav-adhoc
approved these changes
Dec 12, 2024
|
@pedrobaeza Hi! I would like to ask you if it's something missing in this migration in order to be approve |
|
A PSC or maintainer should review it: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review |
|
Hi @rov-adhoc thanks for porting this module. could you rebase, to re build runboat. I'd like to know if the bug described here is still present in the 18.0 branch. (#1896) |
rov-adhoc
force-pushed
the
18.0-mig-account_invoice_fiscal_position_update
branch
from
25ebb65 to
0c47ca8
Compare
|
@legalsylvain thanks for your message. I was able to reproduce the same error in the 18.0 branch. Do you know if anyone is currently working on a fix for this issue? |
I don't know. I just raised this error, using the V16 module. Let's wait what maintainers and original developpers are saying about that bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.